Repository navigation
Name the action on its simulator download (ENG-1686) - #10
Merged
Adam Tauber (asciimoo) merged 1 commit intoOct 30, 2026
Conversation
X-Linro-Client: simulation-github-action/<github.action_ref>, dev when run from a local path. Customers run this action, so the marketplace must be able to count it before enforcing /artifacts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Claude: codex sweep (gpt-6.1-sol), pass 1: CLI review — no actionable findings; persona — MERGE, no material findings. |
Adam Tauber (asciimoo)
marked this pull request as ready for review
October 30, 2026 20:49
Adam Tauber (asciimoo)
deleted the
adamtauber/eng-1686-stamp-every-marketplace-client-with-a-name-and-version
branch
October 30, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ENG-1686 (P-ENG-53). The simulator download sends
X-Linro-Client: simulation-github-action/<github.action_ref>(devfrom a local path). Customers run this action in their CI, so the Marketplace must count it before/artifactsis enforced (cold-review finding on the ENG-1686 set). The ref goes throughenv:, never interpolated into the script. CI exercises the download against the real marketplace.🤖 Generated with Claude Code