Repository navigation
v2: download the simulator from the install with the PAT (ENG-1730) - #11
Merged
Adam Tauber (asciimoo) merged 4 commits intoNov 2, 2026
Conversation
The CLI now comes from <server>/api/simulator/download/... with the token as a bearer, checked against the install's X-Linro-Sha256. server and token are required on every run, dry runs included, and marketplace-url is removed. CI runs against a loopback stand-in install, so it still needs no secret. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every ::error:: is also recorded in $RUNNER_TEMP/linro-simulation-error, and CI checks each refusal failed for its own reason, so a stub failure cannot pass for the sha256 check. version is validated against the install's pattern before any request, and --retry-max-time bounds the whole download at 10 minutes. The README says ca-cert replaces the system roots for the download. Fixes actionlint's required-input findings and SC2129. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Claude: what the cold review found and what changed (bc367f2)
The same push also fixes the earlier lint failure: actionlint's required-input errors (an absent input is now passed as Mutation check: run locally against the stand-in, restored from memory, all 6 caught by the reason check:
|
…adline (ENG-1730) The loopback check matched a prefix, so http://127.0.0.1:80@evil.example sent the token in clear to evil.example. server is now parsed: no user info, query or fragment; plain http only for exactly 127.0.0.1, localhost or [::1] with an optional port; https needs a host name. A loopback install is fetched with --noproxy '*'. The download runs in a deadline loop that gives each attempt the time left, so 10 minutes is one wall-clock bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (ENG-1730) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Claude: what the Codex sweep of bc367f2 found and what changed (head 11167fd)
Mutation check: run locally against the stand-in, restored from memory, 10/10 caught:
Also in this push:
No tag or release was made. |
Adam Tauber (asciimoo)
marked this pull request as ready for review
November 2, 2026 11:16
Adam Tauber (asciimoo)
deleted the
adamtauber/eng-1730-require-a-pat-to-download-the-simulator-served-through-the-action-v2
branch
November 2, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: ENG-1730
What
v2 of the action downloads
linro-simulatorfrom the customer's install instead of anonymously from the Marketplace:GET <server>/api/simulator/download/<version>/<os>-<arch>.tar.gzwithtokenasAuthorization: Bearer. The token goes to curl through a config on stdin, never argv.X-Linro-Sha256header before it runs. This is a second check: the install already verifies the Marketplace's sha256 and cuts the transfer short on a mismatch. A missing header is refused.serverandtokenare required on every run, dry runs included.marketplace-urlis removed.servermust behttps://, or plainhttp://only to a loopback install, so the token never goes over the network in clear.ca-certnow applies to the download too. The download trusts only that bundle, because it goes only to the install. The install step runs inworking-directory, so the path resolves the same way as for the CLI.README, CHANGELOG (new) and the product how-to say this is v2 and why.
@v1keeps downloading anonymously until the Marketplace enforces/artifacts.CI without a secret
CI used to run on
dry-runwith no token at all. It now runs againsttestdata/stub-install.py, a loopback stand-in for the install's download route (bearer token,X-Linro-Sha256). The stand-in takes the tarball from the public Marketplace anonymously. Once/artifactsis enforced in production, CI breaks unless the stand-in gets a key or CI moves to a real install with a secret. New refusal cases:Depends on
The service route in linro-io/service#424. An install without it answers 404. Do not release v2 until that route is deployed to the installs our callers use.
Releasing (not done here: no tag was created or moved)
After merge, from a machine on the IP allow list:
v2.0.0frommainand move the CHANGELOG heading off "unreleased".git tag v2 v2.0.0 && git push origin v2.release.ymlonly verifies the major tag, and it fails with "v2 does not exist" until this is done.v1where it is.Then the callers move to
@v2:github-integration-test(pr-simulate-gateway.yaml:757, plus its own direct download around:213)workflows(terragrunt-plan-apply.yml:1173)simulator-demo(simulate.yaml:81,93, PR only)Tested
I extracted the install step and ran it locally (macOS arm64) against the stand-in:
v0.2.1andlatestdownload, verify and runhttp://example.comrefusedv99.99.99→ 404 messageI could not run shellcheck locally; the CI lint job runs it.
🤖 Generated with Claude Code