Repository navigation
feat(torrent): send torrents through a SOCKS5 or HTTP proxy - #680
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a190fa440f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
09db716 to
fa00f8b
Compare
a190fa4 to
057c470
Compare
fa00f8b to
8dbb866
Compare
057c470 to
301247c
Compare
8dbb866 to
79a019b
Compare
301247c to
1b27e5f
Compare
79a019b to
4f860fd
Compare
1b27e5f to
b9df360
Compare
b9df360 to
d4ffe8a
Compare
Stacked on #679.
What
TorrentConfig.proxy(aProxyAddress, read as the engine starts) sends every torrent through a proxy. The engine then runs overProxiedTorrentNetwork: peer connections are tunneled with SOCKS5CONNECT(user name and password, host names left to the proxy) or HTTPCONNECT(Basic credentials).HttpEngine.withProxy; an engine that cannot use a proxy fails them.[torrent] useProxy(off by default) makes the apps and the CLI pass the manual proxy of[download.proxy]. Settings → BitTorrent → Connections → Use the proxy, for this device; strings in all ten languages.Limits
ketch serverreads it from its config file.Snapshots
Tests
ProxiedTorrentNetworkTest(scripted SOCKS5 and HTTP proxies on loopback: tunnels by address and by name, sign-in, refusals, silent UDP, loopback listener),TorrentSettingsTest(the config switch). The torrent, config, CLI and app JVM suites, the iOS compiles and the Android compile pass locally. No test downloads a whole torrent through a proxy.