Skip to content

test(torrent): fix a race in the adopt-files test - #681

Merged
linroid merged 1 commit into
mainfrom
fix/torrent-adopt-test-race
Nov 14, 2026
Merged

linroid merged 1 commit into
mainfrom
fix/torrent-adopt-test-race

Conversation

@linroid

@linroid linroid commented Nov 14, 2026

Copy link
Copy Markdown
Owner

TorrentAdoptFilesTest failed once on main (Android host tests, after #672) with a FileNotFoundException while creating a torrent.

The test "a folder that holds another unfinished download is not taken" hashed the pack folder into a torrent while another download was already writing into pack/sub, so files and bookkeeping of that download could appear and disappear during the scan.

The torrent is now made before the other download starts. No production code changes.

Verified locally: TorrentAdoptFilesTest passes on the JVM.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T13:36:18.455889Z e3b54da PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Nov 14, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

 2 298 files  ±0   2 326 suites  ±0   58m 22s ⏱️ +4s
16 284 tests ±0  15 999 ✅ ±0  285 💤 ±0  0 ❌ ±0 
19 823 runs  ±0  19 538 ✅ ±0  285 💤 ±0  0 ❌ ±0 

Results for commit e3b54da. ± Comparison against base commit 9d97000.

@linroid
linroid merged commit 2a5e97c into main Nov 14, 2026
15 checks passed
@linroid
linroid deleted the fix/torrent-adopt-test-race branch November 14, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant