Repository navigation
brancher: make the patchwork check name configurable - #136
Merged
Merged
Conversation
This is needed because we have two branchers: for the virtual tests and the hardware ones. They don't have the same gate checks: the hw one has 'contest'. So we need to avoid this conflict. Instead of using a hardcoded 'contest' check name in the pwe_* helpers, take it from the config, like it is done in pw_contest.py: [patchwork] check_name=contest The default value is still 'contest'. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Not only maintainers are looking at PW apparently: makes it clearer which failures block 'contest'. Failed gate checks (here): blocked because of failures: kdoc Hopefully this should help more than causing more confusions. (Maybe we could use another check name rather than re-using 'contest' for that not to indicate two failures on Suie? Or Suie could ignore the checks without links?) Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
It seems clearer with: Failed gate checks (elsewhere in the series): patch id: X While at it, always use the 'extra' part of the message, and remove no longer used conditions. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed because we have two branchers: for the virtual tests and the hardware ones. They don't have the same gate checks: the hw one has
contest. So we need to avoid this conflict.Instead of using a hardcoded
contestcheck name in thepwe_*helpers, take it from the config, like it is done in pw_contest.py:The default value is still
contest.While at it, improve the reported message to avoid confusions.