Skip to content

brancher: make the patchwork check name configurable - #136

Merged
matttbe merged 3 commits into
linux-netdev:mainfrom
matttbe:brancher-gate-report-checks
Nov 13, 2026
Merged

matttbe merged 3 commits into
linux-netdev:mainfrom
matttbe:brancher-gate-report-checks

Conversation

@matttbe

@matttbe matttbe commented Nov 13, 2026

Copy link
Copy Markdown
Member

This is needed because we have two branchers: for the virtual tests and the hardware ones. They don't have the same gate checks: the hw one has contest. So we need to avoid this conflict.

Instead of using a hardcoded contest check name in the pwe_* helpers, take it from the config, like it is done in pw_contest.py:

[patchwork]
check_name=contest

The default value is still contest.

While at it, improve the reported message to avoid confusions.

This is needed because we have two branchers: for the virtual tests and
the hardware ones. They don't have the same gate checks: the hw one has
'contest'. So we need to avoid this conflict.

Instead of using a hardcoded 'contest' check name in the pwe_* helpers,
take it from the config, like it is done in pw_contest.py:

  [patchwork]
  check_name=contest

The default value is still 'contest'.

Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Not only maintainers are looking at PW apparently: makes it clearer
which failures block 'contest'.

  Failed gate checks (here): blocked because of failures: kdoc

Hopefully this should help more than causing more confusions.

(Maybe we could use another check name rather than re-using 'contest'
 for that not to indicate two failures on Suie? Or Suie could ignore the
 checks without links?)

Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
It seems clearer with:

  Failed gate checks (elsewhere in the series): patch id: X

While at it, always use the 'extra' part of the message, and remove no
longer used conditions.

Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
@matttbe
matttbe merged commit 00643e3 into linux-netdev:main Nov 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant