Repository navigation
contest: vm: drop prompt hooks - #140
Merged
Merged
Conversation
Some distributions set PROMPT_COMMAND and PS0 to print extra content around the prompt and each command, e.g. systemd's profile script printing OSC 3008 escape sequences when TERM is not 'dumb'. This content is mixed with the commands output read from the serial console, e.g. 'echo $?' parsed by bash_prev_retcode(). Unset both variables when setting PS1 after the boot, so that only the expected prompt is printed. Note that the current systemd services are already setting TERM=dumb, but it seems better to make sure this feature is always off by setting that here. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some distributions set PROMPT_COMMAND and PS0 to print extra content around the prompt and each command, e.g. systemd's profile script printing OSC 3008 escape sequences when TERM is not 'dumb'.
This content is mixed with the commands output read from the serial console, e.g. 'echo $?' parsed by bash_prev_retcode().
Unset both variables when setting PS1 after the boot, so that only the expected prompt is printed.
Note that the current systemd services are already setting TERM=dumb, but it seems better to make sure this feature is always off by setting that here.