Repository navigation
Remove hard-coded ['drivers/net', 'drivers/net/hw'] - #142
Merged
Merged
Conversation
hw_worker writes net.config only into drivers/net and drivers/net/hw. The kselftest Python lib (drivers/net/lib/py/env.py) reads net.config from the directory of the test being run, so tests in any other target, e.g. a new drivers/net/perf, get none of the NETIF, address and remote settings. Take the targets from the installed test list instead, the same list run_tests() executes. 'make install' generates it from the [ksft] target the orchestrator was configured with, so no extra plumbing via nic-test.env is needed, and --prep-only keeps working on any installed tree. If the list can't be read, warn rather than abort the interface setup. Rename _list_tests() to list_tests() now that it is used outside of lib/runner.py. Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export _list_tests as list_tests and add new _write_net_config to discover the list of subdirs.
Do we keep the slopo-tests or drop?