Skip to content

test: Copy the kernel from its real path when /boot is a subvolume - #276

Closed
HVSharma12 wants to merge 1 commit into
linux-system-roles:mainfrom
HVSharma12:test/boot-subvolume-path
Closed

HVSharma12 wants to merge 1 commit into
linux-system-roles:mainfrom
HVSharma12:test/boot-subvolume-path

Conversation

@HVSharma12

Copy link
Copy Markdown
Contributor

Enhancement:

Copy the test kernel from the path on disk when /boot is a btrfs subvolume.

Reason:

  • On Fedora 44 Cloud /boot is a btrfs subvolume and grubby reports /boot/boot/vmlinuz-... for every kernel. The copy in tests/tasks/clone_kernel.yml then fails, so tests_settings and tests_add_rm fail on Fedora 44 and 45 before the role runs.

Result:

  • The copy uses the path on disk. The kernel paths given to the role are unchanged.
  • All tests pass on Fedora 43, Fedora 44, Fedora 45, CentOS Stream 9 and CentOS Stream 10.

Assisted-by: Claude Code using model(s) Claude Opus 5.5

Issue Tracker Tickets (Jira or BZ if any): https://bugzilla.redhat.com/show_bug.cgi?id=2483604

On Fedora 44 Cloud /boot is a btrfs subvolume and grubby reports
/boot/boot/vmlinuz-..., so the test copy fails. Copy from the path on disk.
The role steps keep grubby's path and pass with it.

Signed-off-by: HVSharma12 <harshvardhan.sharma@suse.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

CI tests do not run automatically on pull requests. A role repository
maintainer can start them by posting a /citest slash command in a
pull request comment.

See GitHub CI testing using /citest
for details.

Run every available CI workflow:

/citest all

Run the linting and other lightweight checks:

/citest linters

Run the integration tests (QEMU/container and Testing Farm):

/citest integration

Run one or more selected workflows by separating their names with spaces:

/citest ansible-lint
/citest ansible-lint markdownlint
Command Check name Description
/citest all All checks listed below Run every CI test available for this role
/citest linters Lint and lightweight checks Run ansible-lint, ansible-test, ansible-managed-var-comment, codespell, markdownlint, pr-title-lint, check-docs-updated, and codeql, python-unit-test, and shellcheck when those workflows exist
/citest integration QEMU/container and Testing Farm checks Run qemu-kvm-integration-tests and tft
/citest ansible-lint Ansible Lint / ansible_lint (<ansible-lint>, <ansible>, <python>) (pull_request) Lint Ansible content after converting the role to collection format
/citest ansible-managed-var-comment Check for ansible_managed variable use in comments / ansible_managed_var_comment (pull_request) Fail if ansible_managed is used in comments
/citest ansible-test Ansible Test / ansible_test (<ansible>, <python>) (pull_request) Run ansible-test sanity tests
/citest codespell Codespell / Check for spelling errors (pull_request) Check for spelling errors
/citest markdownlint Markdown Lint / markdownlint (pull_request) Lint Markdown files
/citest pr-title-lint PR Title Lint / commit-checks Check that the pull request title follows the required format
/citest qemu-kvm-integration-tests Test / scenario (<image>, <env>) (pull_request) Run role integration tests in QEMU VMs and containers
/citest check-docs-updated Run CI tests / check_docs (pull_request) Rebuild README.md and README.html from argument_specs and fail if they are out of date
/citest tft <platform>|ansible-<version> Run integration tests in Testing Farm
/citest woke Woke / Detect non-inclusive language (pull_request) Detect non-inclusive language
/citest codeql CodeQL / Analyze (python) (pull_request) CodeQL security and quality analysis for Python
/citest python-unit-test Python Unit Tests / python (<python>, <os>) (pull_request) Run Python unit tests

Post another /citest comment at any time to run another selection.

@richm

richm commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

This doesn't help when using the bootloader role from another role, like auditd. The other role expects paths to be like /boot/vmlinuz-... instead of /boot/boot/vmlinuz-.... This should be fixed in the bootloader runtime code.

@HVSharma12
HVSharma12 marked this pull request as draft November 18, 2026 14:26
@richm

richm commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

closed - superseded by #277

@richm richm closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants