Repository navigation
Conversation
Reviewer's GuideConfigurationMark the six audited application-manager DConfig keys private while preserving their existing settings and runtime behavior.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xujin177 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本次变更无需修复,代码已正确实现安全加固目标。如需进一步规范,建议确保所有 仅供内部使用的 DConfig 配置项均设置为 "visibility": "private"。本报告由 AI 代码审查工具自动生成 |
1. Mark Exec, TryExec and Icon overrides as private 2. Mark appExtraEnvironments, appEnvironmentsBlacklist and skipEventAppIds as private Log: Application manager internal DConfig keys are marked private Influence: 1. Confirm the six audited keys have private visibility 2. Launch applications and verify session-specific overrides still apply 3. Verify configured application environments are still loaded fix: 将应用管理器内部 DConfig 配置设为私有 1. 将 Exec、TryExec 和 Icon 覆盖项的可见性改为 private 2. 将 appExtraEnvironments、appEnvironmentsBlacklist 和 skipEventAppIds 的可见性改为 private Influence: 1. 确认六个审查项的 visibility 均为 private 2. 启动应用,确认会话相关的启动覆盖仍正常生效 3. 确认应用启动环境配置仍可正常读取 Log: 应用管理器内部 DConfig 配置项已标记为私有 PMS: TASK-398753
xujin177
force-pushed
the
fix/dconfig-public-audit-task-398753
branch
from
November 16, 2026 07:06
b732997 to
a9687e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DConfig audit identified internal settings declared as public. This marks 6 audited keys as private.
private
misc/dsg/configs/dde-application-manager/org.deepin.dde.application-manager.jsonappEnvironmentsBlacklist,appExtraEnvironments,skipEventAppIdsmisc/dsg/configs/dde-application-manager/org.deepin.dde.am.appoverride.jsonExec,Icon,TryExecOnly
visibilityis adjusted. File locations, configuration keys, values, permissions, flags, serials and application code are preserved.The shared appsLaunchedTimes map keeps its existing visibility because dde-am and dde-shell both consume it.
Validation: JSON comparison and
git diff --checkpassed. The affected metadata was loaded with both Qt 5 and Qt 6 DConfig libraries; defaults and existing read/write behavior were checked.This updates the configuration interface declaration; runtime access control is outside this change.
PMS: TASK-398753
Summary by Sourcery
Enhancements: