Skip to content

fix: make application manager DConfig internals private - #399

Open
xujin177 wants to merge 1 commit into
linuxdeepin:masterfrom
xujin177:fix/dconfig-public-audit-task-398753
Open

xujin177 wants to merge 1 commit into
linuxdeepin:masterfrom
xujin177:fix/dconfig-public-audit-task-398753

Conversation

@xujin177

@xujin177 xujin177 commented Nov 16, 2026 •

Copy link
Copy Markdown

The DConfig audit identified internal settings declared as public. This marks 6 audited keys as private.

  1. Mark Exec, TryExec and Icon overrides as private
  2. Mark appExtraEnvironments, appEnvironmentsBlacklist and skipEventAppIds as
    private
Metadata file Keys set to private
misc/dsg/configs/dde-application-manager/org.deepin.dde.application-manager.json appEnvironmentsBlacklist, appExtraEnvironments, skipEventAppIds
misc/dsg/configs/dde-application-manager/org.deepin.dde.am.appoverride.json Exec, Icon, TryExec

Only visibility is adjusted. File locations, configuration keys, values, permissions, flags, serials and application code are preserved.

The shared appsLaunchedTimes map keeps its existing visibility because dde-am and dde-shell both consume it.

Validation: JSON comparison and git diff --check passed. The affected metadata was loaded with both Qt 5 and Qt 6 DConfig libraries; defaults and existing read/write behavior were checked.

This updates the configuration interface declaration; runtime access control is outside this change.

PMS: TASK-398753

Summary by Sourcery

Enhancements:

  • Make six audited application-manager DConfig settings private while preserving their existing keys, values, permissions, flags, serials, and runtime behavior.

@sourcery-ai

sourcery-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Configuration

Mark the six audited application-manager DConfig keys private while preserving their existing settings and runtime behavior.

  • misc/dsg/configs/dde-application-manager/org.deepin.dde.am.appoverride.json L13, L23, L33
  • misc/dsg/configs/dde-application-manager/org.deepin.dde.application-manager.json L13, L23, L33

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xujin177

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次变更将 dde-application-manager 的 6 个 DConfig 内部配置项的 visibility 从 public 改为 private,属于安全加固类修改。变更仅涉及 JSON 配置文件中的 字符串值替换,语法正确、逻辑清晰,无安全漏洞引入,且实际提升了配置安全性。 启发式扫描与 OCR 审查均未发现问题。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例

本次变更无需修复,代码已正确实现安全加固目标。如需进一步规范,建议确保所有 仅供内部使用的 DConfig 配置项均设置为 "visibility": "private"。

本报告由 AI 代码审查工具自动生成

1. Mark Exec, TryExec and Icon overrides as private
2. Mark appExtraEnvironments, appEnvironmentsBlacklist and skipEventAppIds as
   private

Log: Application manager internal DConfig keys are marked private

Influence:
1. Confirm the six audited keys have private visibility
2. Launch applications and verify session-specific overrides still apply
3. Verify configured application environments are still loaded

fix: 将应用管理器内部 DConfig 配置设为私有

1. 将 Exec、TryExec 和 Icon 覆盖项的可见性改为 private
2. 将 appExtraEnvironments、appEnvironmentsBlacklist 和 skipEventAppIds 的可见性改为
   private

Influence:
1. 确认六个审查项的 visibility 均为 private
2. 启动应用,确认会话相关的启动覆盖仍正常生效
3. 确认应用启动环境配置仍可正常读取

Log: 应用管理器内部 DConfig 配置项已标记为私有
PMS: TASK-398753
@xujin177
xujin177 force-pushed the fix/dconfig-public-audit-task-398753 branch from b732997 to a9687e0 Compare November 16, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants