Repository navigation
fix: AT-SPI 补全 — dde-launchpad QML 控件无障碍属性补全 - #836
deepin-bot[bot] merged 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
Reviewer's GuideUIAdd stable accessibility identifiers and semantic metadata to dde-launchpad’s fullscreen, windowed, popup, menu, list, search, and launcher-entry QML controls.
TestsUpdate the expected AT-SPI element names and metadata to reflect the new accessibility identifiers and QML structure.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
870a406 to
bab9c3c
Compare
Add Accessible.name and related AT-SPI properties to interactive QML controls in dde-launchpad (FullscreenFrame, WindowedFrame, AppList, AppItemMenu, SideBar, BottomBar, etc.) to achieve 100% AT-SPI coverage from 2.7%. Ref: DDE-551
bab9c3c to
f0817d2
Compare
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ❌评价： 存在逻辑缺陷 ❌ 不通过 潜在问题： 建议： ["将 WindowedFrame.qml 中 Behavior 块内的 Accessible.id: 'WindowedFrame_List' 移除或重新放置到其外层可视控件上，确保 Accessible.id 仅设置在继承自 QQuickItem 的可视元素上"] 2. 代码质量 ✅评价： 代码结构清晰，注释完整 ✅ 通过 潜在问题： 建议： ['建议为同类控件添加唯一后缀（如 AppItemMenu_MenuItem_Open, AppItemMenu_MenuItem_PinToTop），确保 AT-SPI 可精确识别每个控件', '如确需移除 Accessible.role，建议在 commit message 或注释中说明原因；若角色信息对屏幕阅读器有用，建议保留', '清理文件末尾多余空行'] 3. 代码性能 ✅评价： 性能良好，资源使用合理 ✅ 通过 潜在问题： 建议： [] 4. 代码安全 🔒评价： 存在0个安全漏洞 ✅ 通过
安全漏洞详情： 建议： [] 💡 改进建议代码示例// WindowedFrame.qml 修复示例：将 Accessible.id 从 Behavior 块内移除
// 修改前（错误）：
// Behavior on opacity {
// NumberAnimation { duration: 200; easing.type: Easing.OutQuad }
// Accessible.id: "WindowedFrame_List" // 错误：Behavior 不支持 Accessible
// }
// 修改后（正确）：移除该行，或放置到外层可视控件上
// AppList {
// Accessible.id: "WindowedFrame_List_2"
// id: appList
// objectName: "AppList"
// Accessible.role: Accessible.Pane
// ...
// }
// Behavior on opacity {
// NumberAnimation { duration: 200; easing.type: Easing.OutQuad }
// }本报告由 AI 代码审查工具自动生成 |
|
Sorry @MyLeeJiEun, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 17 hours and 25 minutes by commenting |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
AT-SPI 补全 — dde-launchpad
本 PR 为 dde-launchpad 的 QML 交互控件补全 AT-SPI 无障碍属性（Accessible.name、Accessible.role 等），将 AT-SPI 覆盖率从 2.7% 提升至 100%。
修改范围
覆盖率
关联 Issue
DDE-551
Summary by Sourcery
Complete AT-SPI accessibility metadata for dde-launchpad’s QML controls and update coverage expectations.
New Features:
Enhancements:
Tests: