Repository navigation
feat: defer layer shell anchor config to onCompleted - #842
Merged
Merged
Conversation
1. Move DLayerShellWindow.anchors assignment from property binding to Component.onCompleted handler in launcher item popup 2. The previous direct property assignment could be evaluated before DLayerShellWindow is fully attached, causing anchors to be applied incorrectly or ignored 3. Using Component.onCompleted ensures the layer shell window is fully initialized before setting AnchorNone Log: Fixed launcher popup layer shell anchor initialization timing Influence: 1. Verify the launcher popup/window appears in the correct position without layer shell anchor issues 2. Open and close the launcher multiple times to confirm the popup displays correctly each time 3. Test on different screen configurations and multi-monitor setups 4. Verify the popup does not unexpectedly anchor to screen edges 5. Test app launch via popup and confirm no positioning regressions feat: 将层级外壳锚点配置延迟到 onCompleted 1. 将 launcher 项弹窗中 DLayerShellWindow.anchors 的赋值从属性绑定移至 Component.onCompleted 处理函数 2. 原先的直接属性赋值可能在 DLayerShellWindow 完全附加前就被求值,导致锚 点被错误应用或被忽略 3. 使用 Component.onCompleted 确保在设置 AnchorNone 之前层级外壳窗口已完 全初始化 Log: 修复启动器弹窗层级外壳锚点初始化时序问题 Influence: 1. 验证启动器弹窗/窗口位置正确,无层级外壳锚点问题 2. 多次打开和关闭启动器,确认弹窗每次都能正确显示 3. 在不同屏幕配置和多显示器环境下测试 4. 验证弹窗不会意外锚定到屏幕边缘 5. 测试通过弹窗启动应用,确认无定位回归问题 PMS: BUG-382737
Reviewer's GuideUIDefer the launcher popup’s layer-shell anchor assignment until component completion so it is applied after the window is initialized.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例// 当前写法已为合理修复,无需额外修改。可选优化:若需确保只在首次生效, // 可保持现状即可: // // Component.onCompleted: { // DLayerShellWindow.anchors = DLayerShellWindow.AnchorNone // }本报告由 AI 代码审查工具自动生成 |
BLumia
approved these changes
Nov 9, 2026
robertkill
approved these changes
Nov 9, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, robertkill, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: behind) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Fixed launcher popup layer shell anchor initialization timing
Influence:
feat: 将层级外壳锚点配置延迟到 onCompleted
Log: 修复启动器弹窗层级外壳锚点初始化时序问题
Influence:
PMS: BUG-382737
Summary by Sourcery
Bug Fixes: