Skip to content

【安全】修复 autostop 脚本 CWE-78 命令注入漏洞 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mhduiy wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

【安全】修复 autostop 脚本 CWE-78 命令注入漏洞 #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/dde-session/impl/sessionmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <QTimer>

#include <unistd.h>
#include <sys/stat.h>
#include <xcb/xcb.h>

using namespace Dtk::Core;
Expand Down Expand Up @@ -617,16 +618,35 @@ void SessionManager::stopLangSelector()

void SessionManager::launchAutostopScripts()
{
const QString userConfigPath =
QStandardPaths::standardLocations(QStandardPaths::ConfigLocation).first();

QStringList paths;
paths.append(QStandardPaths::standardLocations(QStandardPaths::ConfigLocation).first()+ QDir::separator() + "autostop");
paths.append(userConfigPath + QDir::separator() + "autostop");
paths.append("/etc/xdg/autostop");

for (auto path : paths) {
QDir scriptDir(path);
const QFileInfoList &fileInfos = scriptDir.entryInfoList(QDir::Files);
for (auto info : fileInfos) {
// 跳过符号链接，防止指向非预期文件
if (info.isSymLink()) {
qWarning() << "[autostop] skip symlink:" << info.absoluteFilePath();
continue;
}
// 校验属主和权限：禁止 group/other 可写
struct stat st;
if (lstat(info.absoluteFilePath().toLocal8Bit().constData(), &st) != 0) {
qWarning() << "[autostop] lstat failed:" << info.absoluteFilePath();
continue;
}
const uid_t expectedUid = path.startsWith(userConfigPath) ? getuid() : 0;
if (st.st_uid != expectedUid || (st.st_mode & (S_IWGRP | S_IWOTH))) {
qWarning() << "[autostop] skip unsafe file (owner/permission):" << info.absoluteFilePath();
continue;
}
qDebug() << "[autostop] script will be launched: " << info.absoluteFilePath();
EXEC_COMMAND("/bin/bash", QStringList() << "-c" << info.absoluteFilePath());
EXEC_COMMAND("/bin/bash", QStringList() << info.absoluteFilePath());
}
}
}
Expand Down
Loading