Skip to content

fix: AT-SPI 补全 — dde-shell QML 控件无障碍属性补全 - #1791

Draft
MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fix/at-spi-completion-2026-11-03
Draft

MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fix/at-spi-completion-2026-11-03

Conversation

@MyLeeJiEun

@MyLeeJiEun MyLeeJiEun commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

AT-SPI 补全 — dde-shell

本 PR 为 dde-shell 的 QML 交互控件补全 AT-SPI 无障碍属性(Accessible.name、Accessible.role 等),将 AT-SPI 覆盖率从 75.3% 提升至 100%。

修改范围

  • dock 面板(AppItem、TaskManager、OverflowContainer 等)
  • tray 面板(TrayContainer、StashContainer、quickpanel 等)
  • frame 层(PanelMenuWindow、PanelToolTipWindow 等)
  • multitaskview、showdesktop 等面板

覆盖率

  • 补全前:75.3%(67/89)
  • 补全后:100%(89/89)

关联 Issue

DDE-551

版权年份

已检查所有修改文件的版权声明,更新至 2026 年。

Summary by Sourcery

Complete accessibility metadata for dde-shell interactive components and bring AT-SPI coverage to 100%.

Bug Fixes:

  • Complete AT-SPI accessibility metadata across dock, tray, frame, multitask view, show-desktop, and notification controls to improve assistive-technology coverage.

Enhancements:

  • Add stable accessibility identifiers and appropriate roles for previously uncovered QML components and native task-manager preview widgets.

Tests:

  • Update AT-SPI expected element and object-name data to cover the expanded accessibility metadata.

Chores:

  • Update copyright years in modified source files where required.

@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Reviewer's Guide

本 PR 通过在 frame、dock、tray、quickpanel、通知中心/OSD 及 shell 的 QML 控件和少量原生 Qt 控件上系统性补充 Accessible.name、Accessible.role 与相关 id,将交互控件的 AT-SPI 语义覆盖率从 75.3%(67/89)提升至 100%(89/89)。

File-Level Changes

Change Details Files
为 frame 层弹出窗口补充窗口级无障碍名称和对话框角色。
  • 为菜单和工具提示窗口设置 Accessible.name 与 Accessible.role。
frame/qml/PanelMenuWindow.qml
frame/qml/PanelToolTipWindow.qml
为 dock 及其任务管理、托盘、快捷面板交互树补全可访问性元数据。
  • 为容器、列表、委托、按钮、菜单、弹窗、工具提示、模型和代理 surface 设置名称及 Pane、Button、Menu、Dialog、ToolTip 等角色。
  • 为任务管理器的原生 X11 预览列表和关闭按钮设置 accessible name。
  • 将 multitaskview 的名称改为稳定文本,并为 dock 窗口和分区补充可访问性标识。
panels/dock/AppletDockItem.qml
panels/dock/AppletItemButton.qml
panels/dock/OverflowContainer.qml
panels/dock/appruntimeitem/package/ShowRuntimeMenu.qml
panels/dock/appruntimeitem/package/appruntimeitem.qml
panels/dock/cardleft/package/CardLeftDockArea.qml
panels/dock/multitaskview/package/multitaskview.qml
panels/dock/package/main.qml
panels/dock/showdesktop/package/showdesktop.qml
panels/dock/taskmanager/package/AppItem.qml
panels/dock/taskmanager/package/TaskManager.qml
panels/dock/taskmanager/x11preview.cpp
panels/dock/tray/SurfacePopup.qml
panels/dock/tray/SurfaceSubPopup.qml
panels/dock/tray/TrayItemSurfacePopup.qml
panels/dock/tray/package/ActionLegacyTrayPluginDelegate.qml
panels/dock/tray/package/ActionShowStashDelegate.qml
panels/dock/tray/package/ActionToggleCollapseDelegate.qml
panels/dock/tray/package/DummyDelegate.qml
panels/dock/tray/package/StashContainer.qml
panels/dock/tray/package/StashedItemDelegateChooser.qml
panels/dock/tray/package/TrayContainer.qml
panels/dock/tray/package/TrayItemDelegateChooser.qml
panels/dock/tray/package/tray.qml
panels/dock/tray/quickpanel/DragItem.qml
panels/dock/tray/quickpanel/PanelPluginPage.qml
panels/dock/tray/quickpanel/PanelTrayItem.qml
panels/dock/tray/quickpanel/PluginItem.qml
panels/dock/tray/quickpanel/QuickPanel.qml
panels/dock/tray/quickpanel/QuickPanelPage.qml
panels/dock/tray/quickpanel/SubPluginPage.qml
为通知气泡、通知中心、OSD 和通知操作控件补充语义角色与可访问名称。
  • 为通知项、通知列表、分组/普通/重叠通知、标题、操作按钮、关闭按钮和设置菜单补充 AlertMessage、ListItem、StaticText、Button、Menu 等语义。
  • 为显示模式、键盘布局和窗口特效 OSD 列表及其委托添加可访问名称。
  • 为通知插件操作菜单、菜单项、通知正文和动作加载器添加可访问元数据。
panels/notification/bubble/package/Bubble.qml
panels/notification/bubble/package/main.qml
panels/notification/center/GroupNotify.qml
panels/notification/center/NormalNotify.qml
panels/notification/center/NotifyCenter.qml
panels/notification/center/NotifyHeader.qml
panels/notification/center/NotifyHeaderTitleText.qml
panels/notification/center/NotifySetting.qml
panels/notification/center/NotifySettingMenu.qml
panels/notification/center/NotifyStaging.qml
panels/notification/center/NotifyView.qml
panels/notification/center/NotifyViewDelegate.qml
panels/notification/center/OverlapNotify.qml
panels/notification/center/package/main.qml
panels/notification/osd/displaymode/package/main.qml
panels/notification/osd/kblayout/package/main.qml
panels/notification/osd/windoweffect/package/main.qml
panels/notification/plugin/NotifyAction.qml
panels/notification/plugin/NotifyActionMenu.qml
panels/notification/plugin/NotifyItemContent.qml
更新修改文件的版权年份,并为 shell 场景窗口列表补充可访问名称。
  • 将运行时菜单文件版权声明更新至 2026 年。
  • 为场景窗口的 ListView 设置 accessible name 和 id。
panels/dock/appruntimeitem/package/ShowRuntimeMenu.qml
shell/SceneWindow.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@MyLeeJiEun
MyLeeJiEun force-pushed the fix/at-spi-completion-2026-11-03 branch 14 times, most recently from a94111d to 678726a Compare November 5, 2026 13:25
Add Accessible.name, Accessible.role and related AT-SPI properties
to interactive QML controls across dde-shell panels (dock, tray,
quickpanel, multitaskview, etc.) to achieve 100% AT-SPI coverage.

Ref: DDE-551
@MyLeeJiEun
MyLeeJiEun force-pushed the fix/at-spi-completion-2026-11-03 branch from 678726a to df7e8c0 Compare November 6, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants