Repository navigation
refactor: remove folder content test suites - #1796
Conversation
1. Remove the taskmanager_qml_api C++ test suite and its mock folder provider plugin 2. Delete the tst_foldercomponents QML test for FolderIcon, FolderContextMenu, and folder popups 3. Drop the panels/dock/taskmanager/qml suite from the QML test runner loop 4. Remove the folder_qml_tests custom target and related CMake wiring 5. Update docs/folder-source-contract.md validation section to drop references to the removed tests The removed tests were being consolidated or relocated elsewhere, so their build targets, mock providers, and documentation references are cleaned up to keep the test configuration consistent. Influence: 1. Verify the remaining tests/CMakeLists.txt only registers the frame/ qml suite and that ctest still runs it 2. Confirm the build no longer produces taskmanagerqmlapi_tests or the test-folder-provider module 3. Verify build and CMake configure pass without missing targets or dangling dependencies 4. Run the remaining test suites and check nothing references the removed targets 5. Check that folder content behavior is still covered by the relocated tests (if applicable) refactor: 移除文件夹内容相关测试套件 1. 移除 taskmanager_qml_api C++ 测试套件及其模拟文件夹插件 2. 删除针对 FolderIcon、FolderContextMenu 与文件夹弹窗的 tst_foldercomponents QML 测试 3. 从 QML 测试运行循环中移除 panels/dock/taskmanager/qml 套件 4. 移除 folder_qml_tests 自定义目标及相关 CMake 配置 5. 更新 docs/folder-source-contract.md 验证章节,删除已移除测试的引用 被移除的测试已被合并或迁移到其他位置,因此清理其构建目标、模拟插件及文档 引用,以保持测试配置的一致性。 Influence: 1. 验证 tests/CMakeLists.txt 仅注册 frame/qml 套件且 ctest 仍可运行 2. 确认构建不再生成 taskmanagerqmlapi_tests 或 test-folder-provider 模块 3. 验证构建与 CMake 配置无缺失目标或悬空依赖 4. 运行其余测试套件,检查无引用已移除目标 5. 检查文件夹内容行为是否仍由迁移后的测试覆盖(如适用) PMS: TASK-398163
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR removes the obsolete taskmanager folder-content test suites, mock provider plugin, and associated CMake/CTest wiring, leaving only the frame QML suite registered by the top-level QML test runner and updating documentation to match the relocated coverage. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
The removed tests were being consolidated or relocated elsewhere, so their build targets, mock providers, and documentation references are cleaned up to keep the test configuration consistent.
Influence:
refactor: 移除文件夹内容相关测试套件
被移除的测试已被合并或迁移到其他位置,因此清理其构建目标、模拟插件及文档
引用,以保持测试配置的一致性。
Influence:
PMS: TASK-398163
Summary by Sourcery
Remove superseded folder-content test infrastructure and update the test configuration and documentation accordingly.
Enhancements: