Skip to content

refactor: remove folder content test suites - #1796

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-398163
Nov 5, 2026
Merged

deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-398163

Conversation

@wjyrich

@wjyrich wjyrich commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
  1. Remove the taskmanager_qml_api C++ test suite and its mock folder provider plugin
  2. Delete the tst_foldercomponents QML test for FolderIcon, FolderContextMenu, and folder popups
  3. Drop the panels/dock/taskmanager/qml suite from the QML test runner loop
  4. Remove the folder_qml_tests custom target and related CMake wiring
  5. Update docs/folder-source-contract.md validation section to drop references to the removed tests

The removed tests were being consolidated or relocated elsewhere, so their build targets, mock providers, and documentation references are cleaned up to keep the test configuration consistent.

Influence:

  1. Verify the remaining tests/CMakeLists.txt only registers the frame/ qml suite and that ctest still runs it
  2. Confirm the build no longer produces taskmanagerqmlapi_tests or the test-folder-provider module
  3. Verify build and CMake configure pass without missing targets or dangling dependencies
  4. Run the remaining test suites and check nothing references the removed targets
  5. Check that folder content behavior is still covered by the relocated tests (if applicable)

refactor: 移除文件夹内容相关测试套件

  1. 移除 taskmanager_qml_api C++ 测试套件及其模拟文件夹插件
  2. 删除针对 FolderIcon、FolderContextMenu 与文件夹弹窗的 tst_foldercomponents QML 测试
  3. 从 QML 测试运行循环中移除 panels/dock/taskmanager/qml 套件
  4. 移除 folder_qml_tests 自定义目标及相关 CMake 配置
  5. 更新 docs/folder-source-contract.md 验证章节,删除已移除测试的引用

被移除的测试已被合并或迁移到其他位置,因此清理其构建目标、模拟插件及文档
引用,以保持测试配置的一致性。

Influence:

  1. 验证 tests/CMakeLists.txt 仅注册 frame/qml 套件且 ctest 仍可运行
  2. 确认构建不再生成 taskmanagerqmlapi_tests 或 test-folder-provider 模块
  3. 验证构建与 CMake 配置无缺失目标或悬空依赖
  4. 运行其余测试套件,检查无引用已移除目标
  5. 检查文件夹内容行为是否仍由迁移后的测试覆盖(如适用)

PMS: TASK-398163

Summary by Sourcery

Remove superseded folder-content test infrastructure and update the test configuration and documentation accordingly.

Enhancements:

  • Remove the obsolete taskmanager folder-content C++ and QML test suites along with their mock provider plugin.
  • Simplify QML test registration to retain only the frame suite and remove the dedicated folder test target.
  • Clean up folder contract documentation to reflect the relocated test coverage.

1. Remove the taskmanager_qml_api C++ test suite and its mock folder
provider plugin
2. Delete the tst_foldercomponents QML test for FolderIcon,
FolderContextMenu, and folder popups
3. Drop the panels/dock/taskmanager/qml suite from the QML test runner
loop
4. Remove the folder_qml_tests custom target and related CMake wiring
5. Update docs/folder-source-contract.md validation section to drop
references to the removed tests

The removed tests were being consolidated or relocated elsewhere, so
their build targets, mock providers, and documentation references are
cleaned up to keep the test configuration consistent.

Influence:
1. Verify the remaining tests/CMakeLists.txt only registers the frame/
qml suite and that ctest still runs it
2. Confirm the build no longer produces taskmanagerqmlapi_tests or the
test-folder-provider module
3. Verify build and CMake configure pass without missing targets or
dangling dependencies
4. Run the remaining test suites and check nothing references the
removed targets
5. Check that folder content behavior is still covered by the relocated
tests (if applicable)

refactor: 移除文件夹内容相关测试套件

1. 移除 taskmanager_qml_api C++ 测试套件及其模拟文件夹插件
2. 删除针对 FolderIcon、FolderContextMenu 与文件夹弹窗的
tst_foldercomponents QML 测试
3. 从 QML 测试运行循环中移除 panels/dock/taskmanager/qml 套件
4. 移除 folder_qml_tests 自定义目标及相关 CMake 配置
5. 更新 docs/folder-source-contract.md 验证章节,删除已移除测试的引用

被移除的测试已被合并或迁移到其他位置,因此清理其构建目标、模拟插件及文档
引用,以保持测试配置的一致性。

Influence:
1. 验证 tests/CMakeLists.txt 仅注册 frame/qml 套件且 ctest 仍可运行
2. 确认构建不再生成 taskmanagerqmlapi_tests 或 test-folder-provider 模块
3. 验证构建与 CMake 配置无缺失目标或悬空依赖
4. 运行其余测试套件,检查无引用已移除目标
5. 检查文件夹内容行为是否仍由迁移后的测试覆盖(如适用)

PMS: TASK-398163
@sourcery-ai

sourcery-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR removes the obsolete taskmanager folder-content test suites, mock provider plugin, and associated CMake/CTest wiring, leaving only the frame QML suite registered by the top-level QML test runner and updating documentation to match the relocated coverage.

File-Level Changes

Change Details Files
Removed the taskmanager QML API C++ test and its mock folder-provider module from the build and test configuration.
  • Deleted the test executable, provider plugin, compile definitions, dependencies, runtime environment, and CTest registration.
  • Removed the associated C++ test and mock provider source files.
tests/panels/dock/taskmanager/CMakeLists.txt
tests/panels/dock/taskmanager/taskmanagerqmlapitests.cpp
tests/panels/dock/taskmanager/testfolderprovider.cpp
Removed the taskmanager folder-content QML test suite and stopped registering that suite with the QML test runner.
  • Deleted coverage for FolderIcon, FolderContextMenu, and folder popup behavior.
  • Limited the QML runner to the frame/qml suite.
  • Removed the folder_qml_tests custom target and its related dependencies and CTest invocation.
tests/panels/dock/taskmanager/qml/tst_foldercomponents.qml
tests/CMakeLists.txt
Updated folder source contract documentation to reflect the relocated test coverage.
  • Removed the validation reference to taskmanager_qml_api while retaining references to frame_qml and file-manager plugin coverage.
docs/folder-source-contract.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交目的是移除 folder content 测试套件,属于重构清理类变更。变更内容为纯删除操作, 涉及 6 个文件:删除 3 个测试源文件(tst_foldercomponents.qml、taskmanagerqmlapitests.cpp、 testfolderprovider.cpp)、修改 2 个 CMakeLists.txt 移除对应构建目标和测试注册、更新 1 个 文档文件移除已删除测试的描述。所有删除操作一致且完整,无遗留引用,无新增代码,不存在 安全漏洞。四维度均通过,代码审查通过。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例


本报告由 AI 代码审查工具自动生成

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy

mhduiy commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

/forcemerge

@deepin-bot

deepin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit 2558bb8 into linuxdeepin:master Nov 5, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants