Repository navigation
test: remove QML panel popup lifecycle smoke tests - #1797
Conversation
1. Remove QML test runner registration and the frame/qml suite from tests/CMakeLists.txt 2. Delete tests/frame/qml/tst_panelpopup.qml which covered PanelPopup open/close, shared window switching, reveal-after-render, and focus loss policies 3. The tests depended on LD_PRELOAD injection of dde-shell-frame and dde-shell-dock libraries plus offscreen QPA, a fragile setup that likely broke in CI environments 4. Native window interactions are already stated to be covered by manual testing, so these smoke tests provided limited automated value Influence: 1. Verify the test suite still configures and builds without the removed qmltestrunner lookup 2. Run ctest to confirm remaining frame/applets/dock coverage targets work as expected 3. Confirm the coverage custom target still executes all remaining module tests 4. Manually validate PanelPopup behavior (open/close, shared window switching, reveal after render, focus loss with closeOnInactive true/ false) since automated coverage is now removed test: 移除 QML 面板弹窗生命周期冒烟测试 1. 从 tests/CMakeLists.txt 中移除 QML 测试运行器的注册及 frame/qml 测试 套件 2. 删除 tests/frame/qml/tst_panelpopup.qml,该文件覆盖 PanelPopup 的打 开/关闭、共享窗口切换、渲染后显示以及焦点丢失策略 3. 这些测试依赖 LD_PRELOAD 注入 dde-shell-frame 和 dde-shell-dock 库并配 合离屏 QPA,这种配置较为脆弱,在 CI 环境中很可能失效 4. 原生窗口交互已由手动测试覆盖,因此这些冒烟测试的自动化价值有限 Influence: 1. 验证测试套件在移除 qmltestrunner 查找逻辑后仍能正常配置和构建 2. 运行 ctest 确认剩余的 frame/applets/dock 覆盖率目标正常工作 3. 确认覆盖率自定义目标仍能执行所有剩余模块测试 4. 由于自动化覆盖已移除,需手动验证 PanelPopup 行为(打开/关闭、共享窗口 切换、渲染后显示、closeOnInactive 为 true/false 时的焦点丢失) PMS: TASK-398163
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the QML PanelPopup lifecycle smoke test and its qmltestrunner-based CTest integration because the LD_PRELOAD/offscreen setup was fragile and offered limited automated value; reviewers should verify the remaining test and coverage targets still configure, build, and run successfully, then manually validate the removed PanelPopup behaviors. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Influence:
test: 移除 QML 面板弹窗生命周期冒烟测试
Influence:
PMS: TASK-398163
Summary by Sourcery
Remove the unreliable QML PanelPopup lifecycle smoke tests and simplify the test suite configuration.
Enhancements:
Tests: