Repository navigation
Show the verifier's hints in the State Machine view - #172
Open
CatarinaGamboa wants to merge 1 commit into
Open
CatarinaGamboa wants to merge 1 commit into
CatarinaGamboa wants to merge 1 commit into
Conversation
CatarinaGamboa
force-pushed
the
feat/focus-collapse
branch
from
October 27, 2026 12:33
cdfeb0c to
eca3f3e
Compare
CatarinaGamboa
force-pushed
the
feat/fsm-ways-to-fix
branch
from
October 27, 2026 12:33
a2f3b5f to
88adc68
Compare
CatarinaGamboa
added a commit
that referenced
this pull request
Oct 27, 2026
CatarinaGamboa
force-pushed
the
feat/fsm-ways-to-fix
branch
from
October 27, 2026 17:17
88adc68 to
ba7fdc5
Compare
CatarinaGamboa
changed the title
CatarinaGamboa
force-pushed
the
feat/fsm-ways-to-fix
branch
from
October 27, 2026 20:51
ba7fdc5 to
acc19fe
Compare
CatarinaGamboa
force-pushed
the
feat/focus-collapse
branch
from
October 27, 2026 20:51
9231f80 to
a92a0c9
Compare
The State Machine view showed where a call is rejected but not how to fix it, while the verifier's hints were only in the Verification tab. A collapsed "Ways to fix" section under the legend now lists the hints of the shown error, as in the Verification tab. Nothing is read from the diagram, which ignores the transitions' conditions and the code. Its open state is kept per error, apart from the Verification tab's hints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CatarinaGamboa
force-pushed
the
feat/focus-collapse
branch
from
October 28, 2026 13:57
a92a0c9 to
782e902
Compare
CatarinaGamboa
force-pushed
the
feat/fsm-ways-to-fix
branch
from
October 28, 2026 13:57
acc19fe to
6d41838
Compare
CatarinaGamboa
added a commit
that referenced
this pull request
Oct 28, 2026
… on hover (#171) Part of #170. ## Why Focus mode dimmed the methods unrelated to a state error but kept their text, so the layout did not move (#158). On a large machine the dimmed label stacks still took the space. In the UDP chat client the state the error is about, `closed`, was below the fold. ## What In focus mode: - **Collapse.** The dimmed methods of each label become a count: `receive` + `+9 more`, or `2 methods`. Overloads count once. A single dimmed method keeps its name and conditions. - **List on hover.** Hovering a count lists its methods, with their conditions, next to the label. A click keeps the list open until the next click, a pan or a zoom. The diagram is not laid out again, so the list appears at once. The list goes right, left, above or below the label, or beside the diagram at the label's height: wherever it covers the fewest states, labels and transition lines, and the closest such place on a tie. - **Constructors.** The constructors of each state are merged into one arrow, e.g. `4 constructors`. - **Layout.** The diagram is laid out again. A tall diagram is shrunk to fit the panel, but never below 60%. - **Bright.** Only the failed method stays bright. - **States.** No state is removed. **Show all** is unchanged. An earlier version of this PR also drew a dashed "way to an expected state": a shortest path along the diagram's transitions. It was dropped. The path ignores the transitions' conditions and the code, and for a state that no call leaves (`closed`) it could only suggest creating a new object. The ways to fix now come from the verifier's hints only (#172). Error categories (liquid-java/liquidjava#418) are not used to choose what to show. #170 explains why. ## Screenshots Real verifier output (0.0.36) in headless VS Code. **UDP chat client** (`E_OSS_A1_22`): `receive` after an `if` that may close the socket. In the screenshots, the three `from = "closed(this) && connected(old(this))"` preconditions are removed from the DatagramSocket spec. With them, verifier 0.0.36 sends no state context or hints for this error, and the view can only say "Invalid method call at line 28". That is a verifier issue, separate from this PR. | Before | After | |---|---| | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/udp-before.png" width="440"> | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/udp-after-v2.png" width="440"> | **On hover**, placed off the states and transitions: `+12 more` next to `bound` goes beside the diagram, `+16 more` next to `connected` to its right, and the `2 methods` of `ImageWriteParam` left of `tilingExplicit` and right of `setTiling`. | UDP, `bound` | UDP, `connected` | |---|---| | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/udp-hover-bound.png" width="440"> | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/udp-hover-connected.png" width="440"> | | ImageWriteParam, bottom | ImageWriteParam, middle | |---|---| | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/iwp-hover-bottom.png" width="440"> | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/iwp-hover-middle.png" width="440"> | **ImageWriteParam**: `setTiling` from `startTiling`. | Before | After | |---|---| | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/iwp-before.png" width="440"> | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/iwp-after-v2.png" width="440"> | <details><summary>Show all (unchanged)</summary> <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/focus-collapse/udp-show-all.png" width="440"> </details> The collapsed "Ways to fix" section in the screenshots comes from the stacked PR. ## Tests - `npm run test:unit`: 123 passed. New tests cover collapsing, the list on hover, pinning it with a click and closing it on a click, pan or zoom, placing it off the states, labels and lines and inside the panel, merging constructors and the entry transitions from #169, the fit to the panel, and Show all being unchanged. - `tsc -p tsconfig.test.json` and `npm run lint`: clean. - `npm test` (VS Code): 9 + 1 passing, and server `mvn test`: 35 passing, both run on the stacked branch, which includes this one. Rebased on #169. In focus mode, entry transitions are dimmed and merged per state, the same way constructors are. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #170. Stacked on #171, so review that one first.
Why
The State Machine view showed where a call is rejected but not how to fix it. The verifier's hints were only in the Verification tab.
What
A collapsed Ways to fix section under the legend lists the verifier's hints for the shown error, rendered as in the Verification tab, with several call sequences shown as options. The verifier's own "(and possibly others)" stays in its hints.
Nothing is read from the diagram. An earlier version also listed shortest paths along the diagram's transitions, but they ignore the transitions' conditions and the code, so they were dropped (see #171).
Other details:
Drawing a selected verifier hint on the diagram is #156. That issue now lists what it needs first.
Screenshots
Section opened, real verifier output (0.0.36).
UDP chat client. The verifier says the state depends on the path.
ImageWriteParam. The verifier names the argument that decided the state.
Tests
npm run test:unit: 127 passed. New tests cover the hints, the collapsed default and its key, an error that cannot be marked, no section without hints, and the open state across tabs.tsc -p tsconfig.test.jsonandnpm run lint: clean.npm test(VS Code): 9 + 1 passing. Servermvn test: 35 passing.🤖 Generated with Claude Code