Skip to content

Include new Rust token source - #36

Merged
MaxHeimbrock merged 4 commits into
mainfrom
max/include-token-source
Aug 25, 2026
Merged

Include new Rust token source#36
MaxHeimbrock merged 4 commits into
mainfrom
max/include-token-source

Conversation

@MaxHeimbrock

@MaxHeimbrock MaxHeimbrock commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Adds a tab to the connection options:

Screenshot 2026-08-13 at 11 14 30

@MaxHeimbrock
MaxHeimbrock force-pushed the max/include-token-source branch from 104e7e0 to 86cc4b7 Compare July 22, 2026 14:20
@MaxHeimbrock
MaxHeimbrock force-pushed the max/include-token-source branch from 82dc6df to c00f555 Compare August 3, 2026 14:54
@MaxHeimbrock
MaxHeimbrock marked this pull request as ready for review August 13, 2026 09:19
@MaxHeimbrock
MaxHeimbrock requested a review from ladvoc as a code owner August 13, 2026 09:19
Sandbox id works, but no other fields possible yet

Cargo changes for local dev

Also have fields for all fetch options

Some cleanup after CI complained

Adapt to fetch options builder

Using factory pattern

Make cargo toml use real deps

Needed for rebase

Adapt to stream options builder API

StreamTextOptions and StreamByteOptions no longer implement Default in
the local rust-sdks checkout; construct them via new_with_topic and
with_destination_identities instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Adapted to newest version

Adjusted to basic factory constructor

Working version matches

Format check
@MaxHeimbrock
MaxHeimbrock force-pushed the max/include-token-source branch from 344e61f to 9c3d871 Compare August 24, 2026 08:25
@MaxHeimbrock
MaxHeimbrock requested a review from 1egoman August 24, 2026 10:17

@1egoman 1egoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, called out a few nitpicks / small suggestions I think could make it a little more elegant!

Comment thread src/connect.rs Outdated
Comment thread src/connect.rs Outdated
Comment thread src/connect.rs Outdated
Comment thread src/connect.rs Outdated
Comment thread Cargo.toml Outdated
MaxHeimbrock and others added 3 commits August 24, 2026 15:38
@MaxHeimbrock
MaxHeimbrock merged commit a18c261 into main Aug 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants