Skip to content

LK Capture integration - #276

Open
stephen-derosa wants to merge 33 commits into
mainfrom
sderosa/capture-no-device-source
Open

stephen-derosa wants to merge 33 commits into
mainfrom
sderosa/capture-no-device-source

Conversation

@stephen-derosa

@stephen-derosa stephen-derosa commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

#227 minus device capture source and addressing comments.

This implementation assumes that the livekit capture build is behind a build arg which would bring in gstreamer deps (very large)

Copilot AI balanced review requested due to automatic review settings October 9, 2026 17:26
@stephen-derosa
stephen-derosa requested review from a team and xianshijing-lk as code owners October 9, 2026 17:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

devin-ai-integration[bot]

This comment was marked as resolved.

@stephen-derosa
stephen-derosa requested a balanced review from Copilot October 9, 2026 19:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread cmake/run_cargo.cmake
Comment thread .github/workflows/builds.yml Outdated
Comment thread .github/workflows/builds.yml
Comment thread .github/workflows/make-release.yml Outdated
Comment thread docs/building.md
Comment thread docs/capture-sources.md
Comment thread .build-info.json.in
Comment thread include/livekit/video_source.h
Comment thread src/tests/integration/test_capture_source.cpp Outdated
Comment thread src/tests/CMakeLists.txt Outdated
Comment thread src/capture_source_internal.h Outdated
Comment thread .github/actions/build-sdk/action.yml
devin-ai-integration[bot]

This comment was marked as resolved.

@stephen-derosa
stephen-derosa force-pushed the sderosa/capture-no-device-source branch 4 times, most recently from a21d2ec to 4c67c5a Compare October 13, 2026 17:15

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

5 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)

Devin Review

Comment thread docker/linux-build.Dockerfile Outdated
@stephen-derosa
stephen-derosa force-pushed the sderosa/capture-no-device-source branch from 1f16247 to 31d42b2 Compare October 13, 2026 20:48
@stephen-derosa stephen-derosa self-assigned this Oct 14, 2026
@stephen-derosa
stephen-derosa force-pushed the sderosa/capture-no-device-source branch from 29ddf8f to a990fad Compare October 14, 2026 16:32
Comment thread .github/workflows/builds.yml Outdated
Comment thread .github/actions/check-sdk-abi/action.yml Outdated
Comment thread .github/actions/setup-capture/action.yml Outdated
Comment thread docs/building.md Outdated
Comment thread docs/building.md Outdated
Comment thread docker/linux-build.Dockerfile Outdated
Comment thread include/livekit/capture/capture_source.h
Comment thread include/livekit/capture/capture_source.h
@stephen-derosa

stephen-derosa commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator Author

todo: cherry-pick 1fa7f6020b60a6ce77f5a7c7f47aede830ff06b0 once CI is passing

Done

Comment thread include/livekit/capture/capture_source.h

@alan-george-lk alan-george-lk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve pending CI working on latest Rust release

@stephen-derosa
stephen-derosa force-pushed the sderosa/capture-no-device-source branch from 171f99d to e625513 Compare October 23, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants