Skip to content

Bump cpp-example-collection from 7abd4b9 to 90f13f1 - #293

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/submodules/cpp-example-collection-90f13f1
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/submodules/cpp-example-collection-90f13f1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 21, 2026

Copy link
Copy Markdown
Contributor

Bumps cpp-example-collection from 7abd4b9 to 90f13f1.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [cpp-example-collection](https://github.com/livekit-examples/cpp-example-collection) from `7abd4b9` to `90f13f1`.
- [Commits](livekit-examples/cpp-example-collection@7abd4b9...90f13f1)

---
updated-dependencies:
- dependency-name: cpp-example-collection
  dependency-version: 90f13f11a081281924f1bffc5d2eda4182e5e544
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Oct 21, 2026
@dependabot
dependabot Bot requested review from a team and xianshijing-lk as code owners October 21, 2026 16:33
@dependabot dependabot Bot added the submodules Pull requests that update submodules code label Oct 21, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread cpp-example-collection
@@ -1 +1 @@
Subproject commit 7abd4b97aebd33a681cfbbed9b739fdc5c2c17e3
Subproject commit 90f13f11a081281924f1bffc5d2eda4182e5e544

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Ubuntu 22.04 examples use incompatible SDK

On Ubuntu 22.04, _lk_detect_host selects the 24.04 bundle despite a published 22.04 bundle. Its newer glibc dependencies can prevent the examples from running.

Learn more

The example collection downloads an SDK release when LIVEKIT_LOCAL_SDK_DIR is unset. Its updated _lk_detect_host treats every Linux host as Ubuntu 24.04, while the SDK release workflow builds distinct 22.04 and 24.04 artifacts. Ubuntu 22.04 users therefore receive an artifact built against a newer system libc, so compiling or launching the examples can fail. In-tree SDK builds supply a local SDK and do not exercise this download path.

Example: On an Ubuntu 22.04 x64 machine, configuring the examples without LIVEKIT_LOCAL_SDK_DIR requests livekit-sdk-ubuntu-24.04-x64-<version>.tar.gz, not the available livekit-sdk-ubuntu-22.04-x64-<version>.tar.gz. The resulting binary can fail to load with a missing GLIBC version.

Recommended fix: Update _lk_detect_host in the example collection to select the matching Ubuntu release for Linux hosts, including a clear failure for unsupported hosts. Keep its triple names aligned with the release matrix.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants