Repository navigation
Add session stop API, store session tokens - #83
Merged
Merged
Conversation
Store token from `reserved` events and make them available to session events. Add LiveRunnerRegistration.stop_session() so apps can stop sessions before receiving application traffic.
There was a problem hiding this comment.
🟡 Changes recommended
Session callbacks can receive empty tokens despite cached credentials, breaking operations that rely on the event token.
1 open issue
What changed in this PR
Adds token-backed session management so live-runner apps can stop reserved sessions before receiving application traffic.
Changes:
- Cache reservation tokens and expose a token field on session events.
- Add
stop_session()with credential validation and replacement-reservation protection. - Add tests for stopping sessions, failure handling, and token refresh behavior.
| File | Description |
|---|---|
| tests/test_live_runner.py | Tests session stopping and reservation-token tracking. |
| src/livepeer_gateway/live_runner.py | Adds token storage, event token exposure, and the stop API. |
| CHANGELOG.md | Documents the new session-management API and event field. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store token from
reservedevents and make them available to session events.Add LiveRunnerRegistration.stop_session() so apps can stop sessions before receiving application traffic.