Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues, and the syntax modernization preserves behavior on the supported Python versions.
No open issues 🎉
What changed in this PR
Enables Ruff in CI and modernizes Python syntax across the gateway package to support repository-wide lint enforcement.
Changes:
- Activates the existing Ruff CI job.
- Modernizes type annotations and collection imports.
- Replaces
asyncio.TimeoutErrorwith built-inTimeoutError, compatible with the supported Python versions.
| File | Description |
|---|---|
src/livepeer_gateway/trickle_subscriber.py |
Modernizes optional and forward-reference annotations. |
src/livepeer_gateway/trickle_publisher.py |
Updates annotations, collection imports, and timeout handling syntax. |
src/livepeer_gateway/token.py |
Modernizes an optional annotation. |
src/livepeer_gateway/segment_reader.py |
Modernizes optional and header annotations. |
src/livepeer_gateway/remote_signer.py |
Modernizes optional annotations. |
src/livepeer_gateway/media_publish.py |
Updates annotations, collection imports, and timeout handling syntax. |
src/livepeer_gateway/media_output.py |
Modernizes optional and forward-reference annotations. |
src/livepeer_gateway/media_decode.py |
Modernizes union, optional, and queue annotations. |
src/livepeer_gateway/control.py |
Modernizes optional task annotations. |
src/livepeer_gateway/channel_writer.py |
Modernizes optional writer and task annotations. |
src/livepeer_gateway/channel_reader.py |
Removes quotes from a segment reader annotation. |
pyproject.toml |
Updates a comment to describe repository-wide lint enforcement. |
.github/workflows/tests.yml |
Removes the condition disabling Ruff. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.