Skip to content

Fix issue from recent flux versions not automatically clearing environment - #229

Merged
mplegendre merged 1 commit into
llnl:develfrom
mplegendre:bugfix/flux_unsetenv
Oct 7, 2026
Merged

mplegendre merged 1 commit into
llnl:develfrom
mplegendre:bugfix/flux_unsetenv

Conversation

@mplegendre

Copy link
Copy Markdown
Member

Flux used to run the spindle plugin under a relatively cleaned set of environment variables. As of recent versions its not cleaning environment variable during its startup. This led to issues when:

  1. Set an environment variables, such as SPINDLE_DEBUG
  2. Get a flux allocation
  3. Unset SPINDLE_DEBUG
  4. Run spindle

And spindle would run with SPINDLE_DEBUG set, because it inherited it from an uncleaned parent process.

This commit adds 'unsetenv' calls to clear environment variables if they're no longer set in the launching shell.

@nchaimov nchaimov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also ran this through the E4S testsuite and no new failures occurred.

@mplegendre
mplegendre merged commit bd0657f into llnl:devel Oct 7, 2026
6 checks passed

This branch was previously deployed

1 inactive deployment
Spindle CI — 56b9a778 Deployed Oct 6, 2026 by mplegendre via Testsuite (Slurm srun, Ubuntu) #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants