Skip to content

Fix signal registration before crash handler init - #231

Merged
nchaimov merged 1 commit into
llnl:develfrom
ParaToolsInc:crash-sigchain-fix
Oct 9, 2026
Merged

nchaimov merged 1 commit into
llnl:develfrom
ParaToolsInc:crash-sigchain-fix

Conversation

@nchaimov

@nchaimov nchaimov commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes a bug in the crash handler where an application-registered signal handler would not be honored until Spindle's signal handler was installed. Previously, Spindle would intercept the signal family of functions and store the signal handler for its own use unconditionally. Thus, if an application signal handler was registered before Spindle's was installed, and a signal was in fact delivered before Spindle's handler was installed, the application handler would be ignored and the default disposition would occur instead. This manifested in Java 27 crashing when it intentionally segfaults early in execution as part of CPU feature detection. This is fixed by passing through to the original function until Spindle's signal handler is installed.

@nchaimov
nchaimov merged commit a4b7f35 into llnl:devel Oct 9, 2026
6 checks passed

This branch was previously deployed

1 inactive deployment
Spindle CI — bb0d8159 Deployed Oct 8, 2026 by nchaimov via Testsuite (Slurm rshlaunch, Ubuntu) #278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant