Repository navigation
Fix signal registration before crash handler init - #231
Merged
Merged
Conversation
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the crash handler where an application-registered signal handler would not be honored until Spindle's signal handler was installed. Previously, Spindle would intercept the
signalfamily of functions and store the signal handler for its own use unconditionally. Thus, if an application signal handler was registered before Spindle's was installed, and a signal was in fact delivered before Spindle's handler was installed, the application handler would be ignored and the default disposition would occur instead. This manifested in Java 27 crashing when it intentionally segfaults early in execution as part of CPU feature detection. This is fixed by passing through to the original function until Spindle's signal handler is installed.