Repository navigation
Preserve safe diagnostic causes and graph sync cursors - #114
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Journal replaced distinct sync, storage and native failures with generic Diagnostics messages, making the reported
applyAuthoritative.failedimpossible to distinguish. Preserve bounded reason codes and safe technical context from each producer through the runner, worker/service and Swift Diagnostics. Also show graph-scoped Local tx (applied service checkpoint) and Remote tx (largest observed service transaction), using exact Int64 decimal strings.Changes
Validation
729 OCaml Alcotest cases pass: application 148, worker runner 50, worker reducer 20, sync 327, overlay storage 86 and overlay sync 98. Worker service suite also passes.
Swift owner tests and iOS source typecheck pass, including real OCaml/C/Swift runtime/crypto boundary fixtures. Build-helper suite: 55 run, 54 passed, 1 skipped. Isolated native display checks verify full integrity context, HTTP 503 and cursor precision; they are separate from normal-App sync acceptance.
Final-source normal Simulator candidate 1.5877.6506 was installed as a data-preserving update and tested with the existing Web App on the designated synthetic test graph. Passed Capture→Web and Web→Journal creation, exact UUID/parent identity, remote edits while an append draft stays open, subsequent Journal child append, synthetic deletion/Undo restoring the same UUID, cold-start catchup without Capture, native Photos upload of a generated 32×32 image, Web image rendering and native full-screen preview. Timeline multi-day content/reselect-to-top, detail/back/copy and Diagnostics pass. Applied/observed tx progressed 933→949; final outbox is zero. No integrity failure was observed in these cases. Test blocks remain available.
Final native/Swift source-input hashes match the tested product tree; strict app signature verification and
git diff --checkpass. Product code is unchanged after the 6506 acceptance. The existing wrapped-key crypto harness now verifies the precise authentication response, exactly one operation-matched terminal record, its failing stage and a nonnegative integer duration; existing opt-in/privacy/cap/recovery checks remain. This test-only correction reproduces and fixes the first CI run's stale generic-result expectation and passes locally.GitHub Journal CI passes on final head
3ce09ad0c515f06dfe26634f46a98661945364e9: run 259, including all-target build and full regression suite. Automated code review completed with no findings on product commitac3dd2e; the subsequent commit changes only the existing crypto harness and its decision record, and has no new automated review result.Limits
cross_abi_validated=false; no release or TestFlight claim.notImagefailure also reproduced at untouched main. Owner-level checks and iOS source typecheck pass; the actual Simulator image upload/preview passed.