Repository navigation
Add Timeline pull-to-sync with shared sync activity - #115
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging down from the top of Timeline shows “Pull to sync” and “Release to sync”; releasing past the threshold enters the existing online-recovery/pull path. The existing loading indicator left of Options covers Connecting, Pulling and Submitting. Repeated requests retain one forced freshness intent behind the shared pull/submission owner, and completion remains tied to the response and required authoritative commit.
The List keeps its native scrolling and row identity, cancels below-threshold gestures, and clears the hint on release or page exit. Default accessibility copy is English (
Sync,Files,Photos,Camera), as is the photo-add permission description; existing locale-selected translations are retained. No protected spec or Dune changes.Validation:
dune build @alland fulldune runtest --forcepassed, including the public Core single-flight/commit/admission cases and existing header/callback tests.Native acceptance uses the production List, Timeline, header and public sync Core in an isolated synthetic-IO fixture with no real graph/account. It does not establish live service/authentication acceptance. The maintained Simulator host-restamp manifest retains
cross_abi_validated=false; no release/ABI or performance claim is made.