Repository navigation
Resolve captured MyGo input to current retained node identities - #277
Closed
tiensonqin wants to merge 2 commits into
Closed
tiensonqin wants to merge 2 commits into
tiensonqin wants to merge 2 commits into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
Closed as superseded by #276, which includes the capture API from this branch together with the theme/geometry APIs and a combined MyGo dependency pin. The published capture-only pin in this branch passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Backend.InputNode(ui.InputTarget)to resolve MyGo's actual committed hit/focus ancestry to the nearest retained LUI host binding.InputNode.Current()checks visibility and retained incarnation, so delayed pointer actions cannot target a different node that reused the same numeric ID. No geometry inference or private runtime access.Pin the published MyGo capture API from logseq/mygo#1 at
v0.0.0-20261025203821-7875529a3c4d(the exact pinned parity lineage, not upstream main). The integration owner can subsequently combine capture/geometry/theme APIs and update to that reachable lineage.docs/api-migrations.mddocuments the new public contract and duplicate-forwarding rule.Validation in
platform/mygo, without a workspace or temporary replacements (GOWORK=off):CGO_ENABLED=0 go test ./...,go vet ./..., andgo build ./...passed against the published pin.go test -race -count=1 ./...also passed. No GUI testing was performed.Link to Devin session: https://app.devin.ai/sessions/5024f3589d8b4e5d87cb89b53327e279
Open in Devin Desktop: https://app.devin.ai/desktop/session/5024f3589d8b4e5d87cb89b53327e279?variant=devin
Requested by: @tiensonqin