Repository navigation
Expose committed MyGo text and container geometry - #278
Closed
tiensonqin wants to merge 1 commit into
Closed
tiensonqin wants to merge 1 commit into
tiensonqin wants to merge 1 commit into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Backend.TextGeometry(context, nodeID)andBackend.CommittedBounds(context, nodeID)to read the actual committed MyGo text/control layout without reconstructing styles or shaping a second approximation. The backend generation guard rejects patched-but-not-committed state; retained MyGo identities expire on the next build/removal/close. Rune offsets are relative to each rich-text run and coordinates are window DIPs.Requires the production MyGo
Handle.TextGeometry/Handle.CoordinatesAPIs in logseq/mygo@236fd4d. Dependency replacement/pin changes are intentionally left to the desktop host integration branch. Public migration notes document the lifetime and UTF-8/UTF-16 conversion responsibility.Validation:
gofmt,CGO_ENABLED=0 go test ./...,go vet ./..., andgo build ./...passed inplatform/mygo, using an external temporary modfile pointing at the above MyGo API. No temporary replacements or build outputs are committed.Link to Devin session: https://app.devin.ai/sessions/bc6be65b65d1499d8c2861e8136752b8
Open in Devin Desktop: https://app.devin.ai/desktop/session/bc6be65b65d1499d8c2861e8136752b8?variant=devin
Requested by: @tiensonqin