Skip to content

[Test] Fix flaky WireLoggerTest open/close assertion - #243

Merged
jsvd merged 1 commit into
logstash-plugins:mainfrom
jsvd:fix-flaky-wirelogger-test
Nov 4, 2026
Merged

jsvd merged 1 commit into
logstash-plugins:mainfrom
jsvd:fix-flaky-wirelogger-test

Conversation

@jsvd

@jsvd jsvd commented Oct 21, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Fixes flaky WireLoggerTest#wireLoggerLogsOpeningAndClosingConnectionAroundHttpRequest. In log4j 2.17.0, ListAppender#getMessages() returns a snapshot; the test took it once and then waited for messages.size() >= 4, which can never become true if "Closing connection" is logged (asynchronously) after the snapshot. It timed out after 5s.

Each poll now re-reads getMessages() and asserts on the opening/closing patterns with untilAsserted. Test-only change.

How to test this PR locally

./gradlew test --tests '*WireLoggerTest*'. With an artificial Thread.sleep(300) in WireLogger#channelInactive, the old test fails like CI and the new one passes. Full Java suite 55/55 (5 runs); rspec 81/0 on 9.5.5.

Related issues

Scheduled CI failures: https://github.com/logstash-plugins/logstash-input-http/actions/runs/38124473381, https://github.com/logstash-plugins/logstash-input-http/actions/runs/38037532806 (main), https://github.com/logstash-plugins/logstash-input-http/actions/runs/38873041213 (3.x)

🤖 Generated with Claude Code

ListAppender#getMessages returns a snapshot copy, so awaiting on the size
of a list captured once never observed the "Closing connection" message
that the server event loop logs asynchronously after the client closes.
Re-read the messages on every poll and await the actual assertions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Changelog and Version Management

No changelog or version changes detected. You can either update them manually or use a comment command to update them automatically on merge:

/pr_prepare release:<patch|minor|major> — bump version + update changelog
/pr_prepare changelog:add — changelog entry only (no version bump)

/pr_prepare release:patch
- Add the changelog entry here
  - (Additional details can be provided in multiple lines, respecting markdown formatting)

Omit the entry line to use the PR title. If multiple commands are posted, the last one wins.

@jsvd
jsvd marked this pull request as ready for review November 4, 2026 11:50
@jsvd
jsvd merged commit 32af925 into logstash-plugins:main Nov 4, 2026
13 checks passed
@jsvd
jsvd deleted the fix-flaky-wirelogger-test branch November 4, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant