Repository navigation
[Test] Fix flaky WireLoggerTest open/close assertion - #243
Merged
Merged
Conversation
ListAppender#getMessages returns a snapshot copy, so awaiting on the size of a list captured once never observed the "Closing connection" message that the server event loop logs asynchronously after the client closes. Re-read the messages on every poll and await the actual assertions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Changelog and Version ManagementNo changelog or version changes detected. You can either update them manually or use a comment command to update them automatically on merge:
Omit the entry line to use the PR title. If multiple commands are posted, the last one wins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes flaky
WireLoggerTest#wireLoggerLogsOpeningAndClosingConnectionAroundHttpRequest. In log4j 2.17.0,ListAppender#getMessages()returns a snapshot; the test took it once and then waited formessages.size() >= 4, which can never become true if "Closing connection" is logged (asynchronously) after the snapshot. It timed out after 5s.Each poll now re-reads
getMessages()and asserts on the opening/closing patterns withuntilAsserted. Test-only change.How to test this PR locally
./gradlew test --tests '*WireLoggerTest*'. With an artificialThread.sleep(300)inWireLogger#channelInactive, the old test fails like CI and the new one passes. Full Java suite 55/55 (5 runs); rspec 81/0 on 9.5.5.Related issues
Scheduled CI failures: https://github.com/logstash-plugins/logstash-input-http/actions/runs/38124473381, https://github.com/logstash-plugins/logstash-input-http/actions/runs/38037532806 (main), https://github.com/logstash-plugins/logstash-input-http/actions/runs/38873041213 (3.x)
🤖 Generated with Claude Code