fix(python): build GNU/Linux wheels with manylinux_2_28 - #583
Open
szmcdull wants to merge 1 commit into
Open
Conversation
Release currently builds Python wheels on the ubuntu-24.04 host, which tags manylinux_2_39. pip then rejects those wheels on Ubuntu 22.04 (glibc 2.35). Build GNU/Linux wheels in a manylinux_2_28 container instead, matching the musl job's interpreter selection. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-python-sdkjob are taggedmanylinux_2_39because they are built on theubuntu-24.04host without a manylinux container.pipcannot install them on Ubuntu 22.04 (glibc 2.35). PyPIlongbridge==4.5.0already shows this (manylinux_2_39/manylinux_2_39_aarch64).manylinux_2_28container (glibc 2.28), which remains installable on Ubuntu 20.04, 22.04, and 24.04. Windows and macOS keepmanylinux: off. The interpreter flag is aligned with the existing musl job (-i python${{ matrix.python-version }}).Test plan
Release/build-python-sdkGNU/Linux artifacts are taggedmanylinux_2_28(x86_64 and aarch64), notmanylinux_2_39.pip install longbridge --no-index --find-links dist) andimport longbridge.manylinux_2_28and installable on Ubuntu 22.04.