feat: Adds CDC results parsing for Meridian in the CDC flow - #237
Open
nsw-lowrisc wants to merge 1 commit into
Open
feat: Adds CDC results parsing for Meridian in the CDC flow#237nsw-lowrisc wants to merge 1 commit into
nsw-lowrisc wants to merge 1 commit into
Conversation
nsw-lowrisc
force-pushed
the
add_cdc_flow
branch
2 times, most recently
from
July 7, 2026 15:55
23bdb5f to
858050c
Compare
machshev
reviewed
Jul 22, 2026
machshev
left a comment
machshev
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @nsw-lowrisc!
Some nits but the general concept seems fine.
This commit adds parsing of the Meridian CDC reports. The parser is using the meridiancdc.py file in the tools directory, so the parser in the local repo is not required, however, if the report_cmd variable is set in the hjson this will be overridden and the parser called by make. NOTE: the buckets have changed, adding waived and tofix, so the corresponding common_cdc_cfg.hjson file should be updated in line. This required a fix to msg_buckets.py to avoid an exception. Signed-off-by: Neil Webb <nsw@lowrisc.org>
nsw-lowrisc
force-pushed
the
add_cdc_flow
branch
from
September 9, 2026 16:08
858050c to
20125a4
Compare
Author
|
I have made the suggested changes, hopefully thats every thing fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds parsing of the Meridian CDC reports. The parser is using the meridiancdc.py file in the tools directory, so the parser in the local repo is not required, however, if the report_cmd variable is set in the hjson this will be overridden and the parser called by make.
NOTE: the buckets have changed, adding waived and tofix, so the corresponding common_cdc_cfg.hjson file should be updated in line. This required a fix to msg_buckets.py to avoid an exception.