feat: expose a build's options to the run step as {build_opts_file} - #256
Open
martin-velay wants to merge 1 commit into
Open
feat: expose a build's options to the run step as {build_opts_file}#256martin-velay wants to merge 1 commit into
martin-velay wants to merge 1 commit into
Conversation
rswarbrick
reviewed
Sep 1, 2026
martin-velay
force-pushed
the
xcelium_reinvoke_simulator
branch
from
September 1, 2026 10:47
4843503 to
13e6aca
Compare
rswarbrick
reviewed
Sep 3, 2026
rswarbrick
left a comment
rswarbrick
left a comment
Contributor
There was a problem hiding this comment.
This looks nice, and I'm sorry for not getting back more quickly. I've got some suggestions about how to make the code structure a bit clearer, but I'm a fan of the change.
| """Test that a CompileSim records the options it built with, for the run step.""" | ||
| build_dir = tmp_path / "build" / "dir" | ||
| job = _build_compile_sim( | ||
| sim_overrides={"build_dir": str(build_dir), "cov_db_dir": str(tmp_path / "cov")}, |
Contributor
There was a problem hiding this comment.
What does cov_db_dir do here and in the next test?
Contributor
Author
There was a problem hiding this comment.
Added a comment above
A run step that compiles for itself instead of loading the build's
snapshot has to compile the way the build did. Every build now records
its options in build_opts.f, named by the hjson as {build_opts_file}.
Signed-off-by: Martin Velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
xcelium_reinvoke_simulator
branch
from
September 9, 2026 09:34
13e6aca to
4ce9202
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A run step that compiles for itself instead of loading the build's snapshot has to compile the way the build did. Every build now records its options in build_opts.f, named by the hjson as {build_opts_file}.