Repository navigation
ci: run the Miri connection tests one target per runner - #88
Merged
Merged
Conversation
JustinKovacich
added
the
No Issue
zheylmun
approved these changes
Oct 21, 2026
Miri interprets on a single thread, so the connection tests ran end to end on one runner for 24 minutes, most of it the cancellation sweeps in entity_cancel and tester. Each target now runs on its own runner, and a gate job keeps the check name main's ruleset requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JustinKovacich
force-pushed
the
ci/miri-connection-matrix
branch
from
October 21, 2026 18:11
3f18297 to
fc0238f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-rolled Miri job for simple_doip's
connectiontests took 24 minutes on #83, against under a minute for every other job. Setup and compilation took under a minute of that. The rest was Miri interpreting the tests on one thread:--libentityentity_cancelmock_stacktestermiri-connection-targetruns each target on its own runner: the library andmock_stacktogether, thenentity,entity_cancelandtesteralone. The test set and the Miri flags are unchanged.miri-connectionkeeps the name main's ruleset requires, "Miri (simple_doip connection)". It passes only when every leg passed, so the ruleset needs no change.The wall time should fall to the slowest leg, about 8 to 9 minutes. The remaining cost is the drop-at-every-poll sweeps, which this change does not touch.
Issue URL
No issue: a CI duration fix found reviewing #83.
Testing
mock_stackentityentity_canceltesterThe slowest leg now finishes beside rust-ci.yml's own
ci / Miri Tests, 9m24s on this run, so the two Miri jobs set the PR's wait together.🤖 Generated with Claude Code