Repository navigation
Simplify graph image regression tests - #192
Merged
Merged
Conversation
Render each commit row in display order using shared drawing pixels. This avoids dropping commit positions when different rows have identical edge lists. Add a snapshot of three disconnected roots. The old helper fails this snapshot; all 29 graph tests pass with direct row rendering.
Use build_single_graph_row_image for both image uploads and snapshot rows, so commit lookup and fixed-width selection have a single implementation. Snapshot tests continue to use fixed-width images.
Build the annotated canvas from decoded row widths and heights instead of duplicating cell pixel sizes. All 29 graph tests pass with unchanged existing snapshots.
Use one assertion entry point to render, save and compare each snapshot. Compare the generated image in memory instead of reopening the output PNG, while retaining combined mismatch reports and diff images. All 29 graph tests pass. Separate negative checks detect both pixel and dimension mismatches and preserve diagnostic output.
Move snapshot options, annotated image assembly, comparison and diagnostic output into a dedicated child module. Test cases and helper bodies are preserved apart from the visibility needed by their caller.
Place GitRepository under a test-only support module and update its two consumers. Git commands and repository setup behavior stay the same; mailmap tests and the disconnected-root graph case pass.
Register graph tests through the normal module hierarchy and place their snapshot helpers beside them. Update contributor instructions with the new test filter and optional repository dump setting; snapshot file locations stay the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.