Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.2-all.zip

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟣 pre-existing, not blocking: Anyone building the plugin's Android module with this wrapper gets Gradle 9.8.2 paired with AGP 8.2.0. Gradle 9 does not support that AGP version, so the build still fails. The project still applies com.android.tools.build:gradle:8.2.0 (android/build.gradle:12). Gradle 9 removed APIs that older AGP 8.x releases depend on. Fix: pick a wrapper version inside the AGP 8.2.0 range, such as 8.14.3, which example/android already uses. Otherwise bump AGP to a release that supports Gradle 9 in the same PR. Pre-existing: the base 7.5.1 was already below the Gradle 8.2 minimum for AGP 8.2.
A small fix can ride a push you are already making; otherwise a short reply is enough.

Why this was flagged

The trigger is running ./gradlew or opening android/ on its own (IDE sync or CI) after this merge, which downloads gradle-9.8.2-all.zip set at android/gradle/wrapper/gradle-wrapper.properties:5. The buildscript in android/build.gradle:12 still loads AGP 8.2.0 and Kotlin 2.1.20, and the diff leaves both unchanged. AGP 8.2.0 is not on Gradle 9's tested AGP range, and Gradle 9 removed deprecated APIs that older AGP 8.x uses, so configuration fails instead of producing a working build. The base pinned Gradle 7.5.1, which was also below AGP 8.2.0's Gradle 8.2 minimum, so the standalone module was already unbuildable and this bump does not fix it. The impact is limited to standalone builds of the plugin module. Flutter apps that consume the plugin use their own wrapper, for example example/android at gradle-8.14.3 with AGP 8.11.1. Dependabot's version-only bump has no compatibility check against AGP.

Verification: The diff changes only android/gradle/wrapper/gradle-wrapper.properties:5, from gradle-7.5.1-all.zip to gradle-9.8.2-all.zip. android/build.gradle:12 still sets classpath 'com.android.tools.build:gradle:8.2.0'. The base is already broken the same way: AGP 8.2.0 needs Gradle 8.2 or newer, so the base wrapper (7.5.1) fails configuration. This bump makes nothing worse than the base.

Loading