Repository navigation
Skills: tdd, change-review, implement, implement-spec - #73
Merged
Merged
Conversation
…e map, never-cut)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four project skills adapted from mattpocock/skills (MIT), made specific to CertShell.
tdd: red → green in vertical slices, tests only at agreed seams. Uses the realstartApp, mock-idp, ssh-keygen, SQLite and the sshd container; mocks only time and alerts.change-review: Standards (CLAUDE.md, CONTRIBUTING.md, Fowler smells) and Spec (issue / SPEC.md) axes, plus a Security axis (security-reviewer) whenapps/api/src/,Dockerfile,compose*.yamlor.github/workflows/change. Default base isorigin/main. Named so it doesn't clash with the built-in/code-review.implement(user-only): one issue, sec ticket or agreed plan. Seams question, then tdd, commits, change-review, fixes, verify, PR withCloses #N. Sec tickets stay local with no push.implement-spec(user-only): a parent issue's sub-issues plusblocked_byas the task graph. At most 3 worktree implementers, one merger at a time running verify after each merge, then review and fixes; the PR opens only after the security pass (draft if any ticket is stuck).audit-to-tickets: the draft and each ticket now list their seams, soimplement-speccan start without asking.ponytail: the ponytail plugin's core skill moved into the repo and adapted for CertShell: Bun first, a reuse map of the repo's helpers, a never-cut list from SPEC §3/§5/§6, CLAUDE.md wins on tests. Auto-loaded through@.claude/skills/ponytail/SKILL.mdin CLAUDE.md; a freshclaude -psession and its sub-agent both saw it. The plugin is removed from.claude/settings.json.implement/implement-specend with askipped / risk:line.biome.json+.gitignoreskip.claude/worktrees/, sobun run verifypasses while agent worktrees exist (checked with a real worktree).Review pass: ran Terryc21/skill-reviewer's protocol (read only, its code wasn't run) on the 5 skills; applied the fixes (failure paths, vuln gates, serial merger, both-SHA pinning, MIT notices).
Testing: markdown only.
bun run verifypasses. The skills haven't been run end to end yet. The sub-issue, parent and blocked_by endpoints were checked to exist (on #72).