Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/implement-spec/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ the notes dir. Don't paste what they can read.
6. **Advance.** Each merge can widen the frontier: launch implementers for
newly unblocked tickets, keeping the max of 3. Stop when the frontier is
empty; tickets left unmerged are **stuck**.
7. **Review.** Run the `change-review` skill on the integration branch
7. **Review.** Run the `review-code` skill on the integration branch
against `origin/main`. One implementer sub-agent, in its own worktree on
the integration tip like any ticket, fixes every `hard`, `missing`,
`wrong` and security finding (and the rest unless they contradict a
Expand Down
2 changes: 1 addition & 1 deletion .claude/skills/implement/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ release). Same for any issue whose fix turns out to be a vulnerability.
test files as you go; full suite once at the end.
4. **Commit** per logical change (test + code for one slice can share a
commit). No attribution lines.
5. **Review.** Run the `change-review` skill against `origin/main`. Fix every
5. **Review.** Run the `review-code` skill against `origin/main`. Fix every
`hard`, `missing`, `wrong` and security finding; fix `judgement` and
`unasked` ones unless they contradict the ticket, and list any you skip.
Fixes are extra commits. The Security axis covered the earlier commits;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
name: change-review
name: review-code
description: >
Checks a CertShell branch against its issue / SPEC.md and the repo's
CLAUDE.md rules. Use when the user says "change-review", "/change-review",
CLAUDE.md rules. Use when the user says "review-code", "/review-code",
"does this match the issue", "review against the spec", "review since X",
or when `/implement` or `/implement-spec` calls it. Separate axes in
parallel sub-agents: Standards (CLAUDE.md, CONTRIBUTING.md, code smells),
Expand Down
2 changes: 1 addition & 1 deletion .claude/skills/tdd/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Never mock our own modules.
- **One slice per cycle**: one seam, one test, the minimal code.
- **No refactoring in the loop.** Called from `/implement` or
`/implement-spec`: refactor in their review-fix step, after
`/change-review`. Called directly: one refactor pass once everything is
`/review-code`. Called directly: one refactor pass once everything is
green, keeping it green.
- Security behaviour (authz, input checks, headers, rate limits, audit
events) gets a test that fails without the check.
Expand Down
Loading