Repository navigation
Skills: sec findings private only when they could yield a cert, CA key, login or session - #85
Merged
Merged
Conversation
…y, login or session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not every
sec:audit finding needs a private advisory. LOW hardening items (log-format quirks, installer file perms) told an attacker nothing actionable but were blocked from public issues./project-audit: grill asks private vs public persec:finding, recommending private when knowing about it could get someone a cert, the CA key, a login or a session. Report gets aDisclosure:line./audit-to-tickets: filesDisclosure: publicfindings as normal issues; private ones (and anysec:finding without the line, e.g. older reports) stay local files./implement,/implement-spec: vuln gate stops only for fixes meeting the same private rule.Tested:
bun run verifypasses (Markdown-only change; the rule hasn't run through a real audit yet).