Repository navigation
Alerts: defuse mentions, links and line breaks in user-set text - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert titles and bodies included task names and IdP emails verbatim, so a user could make an alert ping a channel (
<!channel>,@here,_@channel) or carry a link (<url|text>,[x](url), plain URLs) to the admins' alert channel.What changed (
apps/api/src/lib/alerts.ts):<or\[):<>→‹›@that starts a word (emails likea@b.cunchanged)](://split by a zero-width space so URLs don't autolink.alerts.test.ts.Tested: new cases in
apps/api/test/alerts.test.tsfor a hostile email on a terminal alert and a hostile task name + email on a task_failed alert (title and body); both fail on the old code.bun run verifypasses (api 140 pass / 10 skip, web 22, root 13).Not covered: bare domains without a scheme can still autolink in Slack; rendering wasn't checked in real Slack/Discord/Mattermost, only the text handed to shoutrrr.