Build required cross-browser and contract test gates - #127
Merged
Conversation
magiccodingman
marked this pull request as ready for review
August 21, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This builds a stronger verification system around Magic IndexedDB and makes it part of the normal pull-request and release paths.
master, and as blocking prerequisites insidepublish-nuget.ymlbefore areleasepush can publishRegressions the stronger tests exposed and fixed
The new assertions found real behavior that the earlier count/key-only comparisons could not detect:
anyOf()batchesTakeLastselected the correct records but returned them reversed in both indexed and cursor pathsOrderBy/OrderByDescendingcursor queries could bypass metadata sorting when no pagination operator was presentTseparator was lowercased by generic case-insensitive string normalization; normalization is now limited to actual string predicates, and date handling accepts valid values across browser realmsnavigator.storage.estimate()now return a safe zero estimate instead of throwingdotnet run; it now launches the exact built DLL on an ephemeral localhost port and reports server stderr on startup failureindexedDB.databases()enumeration API, whose promise can remain unsettled in Playwright's macOS WebKit build; registration and cleanup are verified through standardopen()anddeleteDatabase()requests insteadmacos-15image; Playwright reports itsmacos-14WebKit binary as frozen and no longer updatedCompatibility boundaries
Verification
Local final results:
The existing
masterandreleaserulesets now both require all five checks; the previously disabledreleaseruleset was activated without changing its three-review policy.