Skip to content

docs: add notes on c-ares integration extracted from PR #75 - #259

Merged
manugarg merged 1 commit into
mainfrom
docs/c-ares-notes
Aug 30, 2026
Merged

docs: add notes on c-ares integration extracted from PR #75#259
manugarg merged 1 commit into
mainfrom
docs/c-ares-notes

Conversation

@manugarg

Copy link
Copy Markdown
Owner

Extracted useful design notes and patterns about c-ares integration from the unmerged PR #75 (Google backporting), which is not a priority but contains a well-structured c-ares integration worth learning from.

Saved as docs/c-ares-integration-notes.md. Covers:

  • resolver abstraction (none / getaddrinfo / c-ares function pointer + runtime selection)
  • compile-time gating (HAVE_C_ARES, dummy fallbacks, pkg-config auto-detection)
  • lifecycle ordering and the partial-init cleanup pattern
  • synchronous select() wrapper over c-ares's async API
  • shared result collector keeping output semantics identical across backends
  • new public API, pactester CLI options, and DNS test patterns
  • porting caveats (old c-ares API, known memory bugs, SpiderMonkey vs current QuickJS layout)

Docs-only change; doxygen generation is unaffected (it runs in a temp dir with only pacparser.h).

@sonarqubecloud

Copy link
Copy Markdown

@manugarg
manugarg merged commit 0e69aea into main Aug 30, 2026
30 checks passed
@manugarg
manugarg deleted the docs/c-ares-notes branch August 30, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant