Repository navigation
Conversation
When filterPoints removes the bridge copy of a vertex, the outer ring runs straight through that vertex. A later hole's ray can then hit the vertex and the healed edge at the same x, and findHoleBridge picks the vertex although the hole is outside its angle. If a point was filtered out during hole elimination and the hit vertex doesn't face the hole, bridge to the edge through that vertex instead.
Member
|
Thanks! Also fixed with a much smaller change — I want to keep the code small and not add new complexity if possible. 77019d3 |
Contributor
Author
|
Nice fix, much simpler than mine 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #219
When
filterPointsremoves the bridge copy of a vertex, the outer ring runs straight through that vertex. A later hole's ray can then hit the vertex and the healed edge at the same x, andfindHoleBridgepicks the vertex although the hole is outside its angle. With this PR, if a point was filtered out during hole elimination and the hit vertex doesn't face the hole, the bridge goes to the edge through that vertex.The new test covers both small polygons. It fails on main and passes with this PR.
Details