Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering a component with lazy=True does not reserve its name: another lazy registration silently replaces it, and an eager registration is silently replaced when the original lazy component is later referenced. Check both eager and lazy registries before registering schemas, responses, parameters, headers, examples, and links.
The parameterized regression covers all six component kinds and all four eager/lazy registration combinations, and checks that a rejected duplicate leaves the original definition intact.
Validation on Python 3.12.14 / marshmallow 4.3.1: regression before fix: 12 failed, 12 passed; full suite after fix: 660 passed, 6 skipped. Ruff lint/format and git diff --check pass.