Repository navigation
Fix DateTime timestamp field OpenAPI schema to use minimum instead of min - #1090
Open
logoplanet wants to merge 1 commit into
Open
logoplanet wants to merge 1 commit into
logoplanet wants to merge 1 commit into
Conversation
… min DateTime fields with format="timestamp" and format="timestamp_ms" previously emitted an invalid schema property "min": "0", causing validation failures under openapi-spec-validator. This updates both formats to emit standard "minimum": 0. Fixes marshmallow-code#1064
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DateTime fields configured with
format="timestamp"orformat="timestamp_ms"previously emitted"min": "0"in the generated OpenAPI schema."min"is not a valid OpenAPI numeric constraint keyword, which causesopenapi-spec-validatorto fail schema validation withOpenAPIValidationError: Property 'min' is not allowed.Solution
datetime2propertiesinfield_converter.pyto emit standard"minimum": 0as an integer.ret: dict[str, typing.Any] = {}to maintain strict typing under mypy.tests/test_ext_marshmallow_field.py.tests/test_ext_marshmallow_openapi.py.Fixes #1064