Repository navigation
P0: preserve canonical SV TX fault evidence and make revocation burst-bounded - #327
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical P0 — frequent spontaneous SV STOP on ESP32-P4 preview (COM15)
Device evidence (24 Oct 22:44 UTC)
Operator screenshot shows
SV stopped · board runtime fault. Attached field diagnostics show:83439a4matched; session heartbeat active, lease 6000ms with max observed gap 774msSVLIFE ... stop_cause=RUNTIME_FAULT stop_seq=3 stop_uptime_ms=1308494 stop_hb_age_ms=0SVSYNC EVENT ... state=REVOKED reason=CANONICAL_SV_TX_FAILURE uptime_ms=1308394, ~100ms before forced stopdriver=STARTED link=UPand cumulativeTXfail=30in later log; later SV after manual restart reported 4000 fps, no missesFix (no unsafe optimistic transmission/restart)
esp_err_t, link state when failed, contiguous-failure count, recovery episodes and sticky stop record across subsequent manual START; printSVTXFAULTon every device SHOW. Existing 400-consecutive-failure (~100ms at 4000fps) fail-closed protection remains unchanged.smpSynchauthority and invalidate phase once. Subsequent failed frames continue counting toward STOP without 400 repeated revocations in the 4kHz transmit hot path. Any successful canonical frame resets the contiguous count; no transmission retries, suppression, auto restart or fake synchronization.tests/ptp_profile: 400 consecutive failures, first/last driver errors, link state, sticky evidence after restart and recovery burst semantics.Gates
SVTXFAULT last_stop_first_error,last_stop_last_error,last_stop_link_up+ PTP TXfail, NIC wire capture, Ethernet link evidence. Do not close P0 hardware acceptance from CI alone.Issue #324 remains open until physical stability and independent SV reception verified.