Repository navigation
feat(M4-P0E2B): ACK-gated bounded MULTISV upload, three-MU readback and SELECT protocol - #345
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…er readback Transport-neutral host transaction: decode canonical ARM3, bounded 48-byte serial chunks, each ACK checked for transaction/range, full commit identity and 3-MU firmware SHOW verification before SELECT. Native Linux/Windows regression includes stale staging, corrupt CRC and boot-change guard. Kept draft-only until wired into device controller.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b428508e80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
masarray
force-pushed
the
feat/m4-p0e2b-ack-gated-uploader
branch
from
October 26, 2026 01:42
b428508 to
c49cfe5
Compare
masarray
changed the base branch from
feat/m4-p0e2a-studio-arm3-compile
to
main
October 26, 2026 01:42
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code
M4MultiSvUploadTransactionstate machine, one command per matching firmware ACK.MULTISV STATUS/ABORT/BEGIN/CHUNK/VALIDATE/COMMIT/SHOW/SELECTand bounded 48-byte chunks, zero bulk command blasts.Gate and precise status
This is P0E2B transport-neutral host transaction engine in production Studio build, not yet connected to the running
DeviceController/oneDeviceIoWorker. The GUI must remain DRAFT ONLY until P0E2C wires serial ownership, ACK deadline/timeout, reconnect adoption and validated START. A passing mock-ACK native harness is not physical device acceptance. No 3×4,000fps on-wire claim.Base:
mainwith P0E1 #343 and P0E2A #344 already merged. Issue #333 / ARD M4. Merge only with exact-head CI success.