Repository navigation
feat(M4-P0E3B1): canonical full three-MU board snapshot and read-only Studio inspection - #348
Merged
Merged
Conversation
…udio inspection Firmware UART SHOW now emits BEGIN/8 ROW/END with generation and canonical full-waveform hash including CT shaping, channel quality and enabled. Production Qt reader validates 3 banks sequentially with exact hash, slot/row count/generation and boot session, no auto START or draft overwrite. Integrate through existing sole DeviceIoWorker with bounded timeout and cancellation on errors/port changes; expose Inspect board with per-MU details. Extend existing native M4 harness, no extra CI jobs.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 800af9d5c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Own M4 readback parser via lifetime-scoped unique_ptr behind forward declaration in DeviceController.hpp; include canonical live_signal_transaction before Qt macro definitions in the two concrete translation units. Avoid the Qt slots keyword collision in portable SvFixedPointSineEngine. No extra task/worker, no firmware timing change.
…erve PTP STOP authority Show Inspect board without loaded 3-MU SCD; keep draft Open disabled without qualified SCD. Hold deferred SHOW/PTP SHOW while inspector owns responses and release via m4BoardChanged; preempt inspection for priority PTP STOP/STOP so STOP readback is not starved. Add regression in existing deterministic session harness. Addresses two Codex P2 review findings without additional workflow jobs.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meaningful M4 milestone: firmware-authoritative independent three-MU inspection
SVSTREAM <slot> SHOWemits a single atomic bank snapshot per MU usingSNAP BEGIN/8 ROW/ENDwith per-slot generation and canonicalsv_scenario_hash. Includes all 8 wire channel counts, phase, quality/enabled, fundamental frequency, per-MU CT shaping and TX enable. No dynamic allocation and no work in the 250µs publisher loop.M4ThreeMuBoardReadbackverifies 3 sequential snapshots: exact slot, 8 unique channel rows, full typed bounds, generation, CT shaping, canonical hash, firmware-reported END and verified boot; rejects missing/replayed/mixed/tampered rows. Accepts pristine generation=0 bank.DeviceController/DeviceIoWorker, with worker-write-confirmed readback admission, bounded 6-second timeout, session/boot/disconnect/STOP/deploy/apply invalidation, and strict no-interleaving. SupervisorrequestInspectMultiSvBoardavailable while group is already autonomously RUNNING, no START/STOP or implicit profile mutation.arstack_m4_upload_harnessextended with production parser success and negative cases (duplicate/missing row, altered quality hash, boot epoch), without new CI jobs or workflow matrix changes.docs/M4_P0E3B1_FULL_BOARD_READBACK.md.Scope honesty: This is an explicit read-only full-state inspection and preparation for reconnect adoption, not automatic reconnect detection, proof of selected SCD roster, verified group START, or physical 12kfps/one-PTP capture. Those remain P0E3B2/P0E3C/P0F. M3.H.3 Official Stable unaffected.
CI efficiency: one consolidated commit
800af9d5c81135fc2181d288ee5c7b270276a2bf, only existing exact-head pipelines; no speculative repeated pushes. Tracks #333.