Repository navigation
Conversation
…ation Reuse production ARM3 decoder and uploader per-stream verifier for read-only board/SCD comparison. Boot-scoped live SHOW stream records, full-envelope hash and all 3 MAC/svID/APPID/VLAN/rate/confRev identities must agree. Cache comparison on input changes, add source-aware status and diagnostics, test negative identities in existing M4 harness. Preserve no-START, no GUI draft writes, single serial worker and CI matrix.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fd0598ddf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…verified SHOW records Review P2: previous reconnect roster A was incorrectly kept after operator deployed roster B. Now revoke stale proof immediately after preflight, then adopt only exact three firmware SHOW stream records after SELECT ACK; rejected/incomplete transfers stay UNKNOWN. Assert pre-SELECT absence and post-SELECT source-of-truth reuse in existing M4 harness.
masarray
added a commit
that referenced
this pull request
Oct 28, 2026
Point historical handoff to current ARD-aligned milestone matrix, exact merged baselines and #350 in-progress, safe group START gates, P0F physical acceptance and CI-efficient single-owner production coding rules. Documentation only.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meaningful M4 milestone — read-only board/SCD authoritative identity proof
MULTISV SHOW's three exact STREAM records. Compare with canonical already-compiled ARM3 currently loaded into Studio.MATCHED,MISMATCH,NO SCD,NOT VERIFIEDstatus: recompute only when board boot/roster or engineering source changes. Surface in GUI and engineer diagnostics without overwriting three GUI drafts or modifying board.arstack_m4_upload_harness: negative svID/MAC/APPID/VLAN/rate/wrap/confRev, incomplete/duplicate rows, wrong hash, CRC. Reuse Qt/Windows/firmware CI matrix, no new runners or workflows.Safety boundaries: Identity match is not a proof of 3 bank waveform adoption, TX RUNNING, common PTP/smpCnt, physical 12,000 fps or group START. M4 group START deliberately remains gated. Official Stable M3.H.3 untouched. Does not overlap independent PR #330 LAN autonomy scope. Tracks #333.
Engineer guide:
docs/M4_P0E3B3_SCD_ROSTER_RECONCILIATION.md.