Repository navigation
Use bzl 0.8.0 runfiles keys for test tools - #59
Merged
Merged
Conversation
Signed-off-by: helly25 <6420169+helly25@users.noreply.github.com>
Signed-off-by: helly25 <6420169+helly25@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use bzl 0.8.0's shared runfiles-key helper for named test tools and their manifest. This verifies the published release against bashtest's root and external-module usage.
AG;DR
Resolve bzl 0.8.0 directly from BCR. All temporary bzl archive overrides are removed, including generated consumer modules where applicable. The release dependency is satisfied.
Replace the local path helper with
runfiles.key; declare the public bzl_library dependency.Validation at pushed head
b195868: root suite passed (8 tests, 1 platform skip), both generated external-consumer scripts passed using normal BCR resolution, all 44 Python tests passed, and focused pre-commit passed. All six replacement CI checks passed.No dependency on the other consumer PRs; public bashtest behavior is preserved.