Repository navigation
refactor: remove the typst-title hot-fix - #78
Merged
Merged
Conversation
Quarto renders theorem titles as Typst markup since 1.10.18, so the hot-fix and its option go, and the extension now requires Quarto 1.10.19.
The raw backtick fallback existed for the string-mode titles of the removed hot-fix. Quarto writes titles as content, so title code now takes the themed box. The version-threshold examples move to 1.11.0, above the new minimum.
Walking the whole document boxed code in the document title, which the template writes before the box's definitions, so the render failed with no theme background. The pass walks the body only again.
mcanouil
added
the
Type: Refactor 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarto writes theorem titles as Typst content since 1.10 (quarto-dev/quarto-cli#14261), so the
typst-titlehot-fix and itshotfix.typst-titleoption are gone.The extension now requires Quarto 1.10.19, the latest stable release.
A document that still sets the option renders, with a warning that names the unknown key.
The inline code pass no longer special-cases title scaffolds.
That case only existed for the old string-mode titles, so code in a theorem title now gets the same box as inline code elsewhere.
The pass still walks the body only, which keeps the document title out of it.
The Skylighting override stays.
It redefines Quarto's function to draw the annotation markers, so it keeps its own block styling even though Quarto patches its version since 1.9.27 (quarto-dev/quarto-cli#14126).
The comments now say so.
Checked locally on Quarto 1.10.19:
tests/run.shpasses 31 of 31, including new fixtures for a theorem title with markup and code, and for code in the document title with no theme background.