Skip to content

Enable mcstas-antlr in McCode GitHub CI - #2610

Merged
willend merged 34 commits into
mainfrom
enable-mcstas-antlr-CI
Aug 27, 2026
Merged

Enable mcstas-antlr in McCode GitHub CI#2610
willend merged 34 commits into
mainfrom
enable-mcstas-antlr-CI

Conversation

@willend

@willend willend commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:

Work on CI and selected comps / instrs to enable mcstas-antlr in CI.


Declaration of use of AI-tools

  • Please add a checkmark here if you used AI-tools during the work for this contribution
  • Furter, please describe how / where and for what the tools were used:

Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes patches to an existing component file

    • I have ensured that basic use of the component is OK (e.g. an instrument using it compiles?)
    • I have used the mctest utility to test one or more instruments making use of the component (please attach mcviewtest report as screenshot in comments)
  • My contribution includes patches to an existing instrument file

    • I have used the mctest utility to test the instrument (please attach mcviewtest report as screenshot in comments)
  • My contribution contains something else

    • Explanation is added in free form text above or below the checklist

willend added 30 commits August 25, 2026 13:24
@willend willend changed the title DRAFT: Enable mcstas-antlr in McCode GitHub CI Enable mcstas-antlr in McCode GitHub CI Aug 27, 2026
@willend

willend commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Status:

  • CI in place to run mcstas-antlr on Linux/conda
  • Various minor edits to components and instrument files for succesful mcstas-antlr parsing (a few of them workarounds that warrant work on the mcstas-antlr side.
  • Just one instrument still fails to compile: Test_StatisticalChopper - looks like an issue with INHERIT Montor_nD EXTEND

Have written notes on slack for the things that should be looked at @g5t - can become an issue over at mccode-antlr if you prefer?

@willend

willend commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Merging in time for a full set of nighlies...

@willend
willend merged commit 63943c9 into main Aug 27, 2026
26 checks passed
@g5t

g5t commented Aug 28, 2026

Copy link
Copy Markdown
Contributor
* Just **one** instrument still fails to compile: `Test_StatisticalChopper` - looks like an issue with `INHERIT Montor_nD EXTEND`

I fixed parsing the INHERIT grammar change for StatisticalChopper.comp in mccode-dev/mccode-antlr#302 but must have implemented the rule incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants